Skip to content

fix(input-time-picker): apply aria-label and aria-controls attributes correctly to support NVDA and JAWS #12312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eriklharper merged 4 commits into from
Jun 10, 2025
Merged

fix(input-time-picker): apply aria-label and aria-controls attributes correctly to support NVDA and JAWS #12312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b15d6de
fix(input-time-picker): apply aria-label and aria-controls attributes…
eriklharper Jun 9, 2025
15cde96
add role="group" to the input container for additional context
eriklharper Jun 9, 2025
e57ff5e
fixing accessible test by adding aria-labelledby
eriklharper Jun 10, 2025
c9a61df
adding an inputContainer ID for use with aria-labelledby
eriklharper Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/calcite-components/src/components/input-time-picker/input-time-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,8 @@ export class InputTimePicker
return (
<InteractiveContainer disabled={this.disabled}>
<div
aria-label={getLabelText(this)}
aria-controls={CSS.inputContainer}
aria-labelledby={IDS.inputContainer}
class={{
[CSS.container]: true,
[CSS.readOnly]: readOnly,
Expand All @@ -573,7 +574,13 @@ export class InputTimePicker
role="combobox"
>
<calcite-icon class={CSS.clockIcon} icon="clock" scale={scale === "l" ? "m" : "s"} />
<div class={CSS.inputContainer} dir="ltr">
<div
aria-label={getLabelText(this)}
class={CSS.inputContainer}
dir="ltr"
id={IDS.inputContainer}
role="group"
>
{showMeridiem && meridiemStart && this.renderMeridiem("start")}
<span
aria-label={this.messages.hour}
Expand Down
1 change: 1 addition & 0 deletions packages/calcite-components/src/components/input-time-picker/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@ export const CSS = {
};

export const IDS = {
inputContainer: "inputContainer",
validationMessage: "inputTimePickerValidationMessage",
};
Loading