Skip to content

refactor(combobox): Select All toggle logic#12150

Merged
Elijbet merged 13 commits intodevfrom
elijbet/2311-refactor-select-all-for-combobox
May 27, 2025
Merged

refactor(combobox): Select All toggle logic#12150
Elijbet merged 13 commits intodevfrom
elijbet/2311-refactor-select-all-for-combobox

Conversation

@Elijbet
Copy link
Copy Markdown
Contributor

@Elijbet Elijbet commented May 14, 2025 •
edited
Loading

Related Issue: #11721, #2311

Summary

Refactor the combobox Select All toggle logic.

Elijbet
Elijbet commented May 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@Elijbet Elijbet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfranco Re feedback: #11721 (comment)

I think what Matt is objecting to is that sticky element itself would scroll up the page before sticking to the top. Ours is kind of always stuck 😅

@Elijbet Elijbet marked this pull request as ready for review May 21, 2025 19:26
driskull
driskull requested changes May 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the removal of the css var. If we don't need it we can deprecate it.

Comment thread packages/calcite-components/src/components/combobox-item/combobox-item.scss
Comment thread packages/calcite-components/src/components/combobox/combobox.e2e.ts Outdated
jcfranco
jcfranco approved these changes May 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Before merging, let's extract the new divider CSS prop along the deprecation into a separate PR.

Comment thread packages/calcite-components/src/components/combobox/combobox.tsx Outdated
Comment thread packages/calcite-components/src/components/combobox/combobox.tsx Outdated
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 22, 2025
This was referenced May 23, 2025
Merged
Closed
driskull
driskull approved these changes May 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elijbet Elijbet merged commit b07d396 into dev May 27, 2025
18 checks passed
@Elijbet Elijbet deleted the elijbet/2311-refactor-select-all-for-combobox branch May 27, 2025 20:45
@github-actions github-actions Bot added this to the 2025-06-24 - Jun Milestone milestone May 27, 2025
benelan pushed a commit that referenced this pull request Sep 16, 2025
@Elijbet @benelan
refactor(combobox): Select All toggle logic (#12150)
61867cd 
**Related Issue:** #11721, #2311

## Summary
Refactor the `combobox` `Select All` toggle logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfranco jcfranco jcfranco approved these changes

@driskull driskull driskull approved these changes

Assignees

@Elijbet Elijbet

Labels

pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Milestone

2025-06-24 - Jun Milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Elijbet @jcfranco @driskull