-
Notifications
You must be signed in to change notification settings - Fork 89
feat(action): make actions fill full width of parent #12047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
josercarcamo
merged 12 commits into
dev
from
josercarcamo/7438-horizontal-fill-action-bar
May 21, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f9ddf1a
feat(action-bar, action): make actions fill full width of parent
josercarcamo 0099cd6
Merge branch 'dev' into josercarcamo/7438-horizontal-fill-action-bar
josercarcamo aed0d95
Used queryActions util
josercarcamo d31240a
Merge branch 'josercarcamo/7438-horizontal-fill-action-bar' of github…
josercarcamo 25bc5a5
Merge branch 'dev' into josercarcamo/7438-horizontal-fill-action-bar
josercarcamo 98e9849
Undid changes to action-bar and action-group
josercarcamo 19052a7
Further undoing of code
josercarcamo 3c82c25
Added stretching ability to action only
josercarcamo d345d93
Added full width actions story
josercarcamo 395c987
Merged dev
josercarcamo 7bc3b9b
Used Width from interfaces; added an action to the story; added a ref…
josercarcamo 4c71be9
Merge branch 'dev' into josercarcamo/7438-horizontal-fill-action-bar
josercarcamo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,10 @@ describe("calcite-action", () => { | |
| propertyName: "textEnabled", | ||
| defaultValue: false, | ||
| }, | ||
| { | ||
| propertyName: "width", | ||
| defaultValue: "auto", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add a reflects test as well? |
||
| }, | ||
| ]); | ||
| }); | ||
|
|
||
|
|
@@ -88,6 +92,10 @@ describe("calcite-action", () => { | |
| propertyName: "textEnabled", | ||
| value: true, | ||
| }, | ||
| { | ||
| propertyName: "width", | ||
| value: "full", | ||
| }, | ||
| ]); | ||
| }); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add at least one more full width action here just to improve the demo?