refactor(tokens): Remove unnecessary token data#11915
Merged
Conversation
matgalla
added
the
refactor
jcfranco
added
the
pr ready for visual snapshots
Member
|
+@macandcheese for doc site tooling consideration. |
jcfranco
approved these changes
Apr 9, 2025
| "context": "", | ||
| "mode": "" | ||
| } | ||
| "category": "" |
Member
There was a problem hiding this comment.
Side note: should this be populated in a follow-up PR?
Contributor
Author
There was a problem hiding this comment.
For sure. At the very least, these should follow the same system as the other category fields across tokens. I'll populate this in a separate PR.
macandcheese
reviewed
Apr 9, 2025
Contributor
macandcheese
left a comment
macandcheese
left a comment
There was a problem hiding this comment.
Looks good - just a request to preserve "tier" as well.
Member
|
8 tasks
benelan
pushed a commit
that referenced
this pull request
May 14, 2025
**Related Issue:** #11391 ## Summary Since #11655 allows us to build the final variables with the base token info, we don't need the excess token metadata. This PR removes all the fields within `attributes` from core and semantic tokens aside from the `category` field, which we will keep to assist with niche token instances and documentation purposes. ## Criteria for completion - [x] Remove `attributes` (except for `category`) from all semantic and core tokens - [x] Ensure that organization and token values are retained - [x] Ensure that the token build process is unaffected ## Previous steps - [x] #11852 ## Next steps - Add missing core color tokens - Fix incorrect core color values - Audit the structural differences between tokens and Figma variables - Restructure tokens to align with Figma variables where necessary - Address #10050 - Address #11565 - Address #11581 - Address #11725 - Address #11903 - Audit the value differences between tokens and Figma variables (mainly for percentages and typography) - Finalize token and Figma variable values with Calcite designers and developers - Update token values to align with Figma variables where necessary - Document the new token creation and modification process --------- Co-authored-by: JC Franco <jfranco@esri.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #11391
Summary
Since #11655 allows us to build the final variables with the base token info, we don't need the excess token metadata. This PR removes all the fields within
attributesfrom core and semantic tokens aside from thecategoryfield, which we will keep to assist with niche token instances and documentation purposes.Criteria for completion
attributes(except forcategory) from all semantic and core tokensPrevious steps
style-dictionaryand@tokens-studio/sd-transformsto latest #11655Next steps