Skip to content

chore(linting): fix lint-staged errors#11887

Merged
jcfranco merged 2 commits intodevfrom
jcfranco/fix-lint-staged-not-finding-markdownlint-cli2-config
Apr 8, 2025
Merged

chore(linting): fix lint-staged errors#11887
jcfranco merged 2 commits intodevfrom
jcfranco/fix-lint-staged-not-finding-markdownlint-cli2-config

Conversation

@jcfranco
Copy link
Copy Markdown
Member

@jcfranco jcfranco commented Apr 7, 2025

Related Issue: N/A

Summary

Fixes errors that came up after recent linting-related updates.

Notes

  • Resolves markdownlint-cli2 config path properly
  • Ensures .mjs files are included in ESLint configs (TS-related)
  • Prevents markdownlint-cli2 from processing node_modules in packages by moving dev dependencies to the root
  • Adds type annotations to lint-staged.config.mjs files

@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Apr 7, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Apr 7, 2025
Copy link
Copy Markdown
Contributor

@aPreciado88 aPreciado88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jcfranco
Copy link
Copy Markdown
Member Author

jcfranco commented Apr 8, 2025

Taking another stab at this as I encountered a a lint/commit issue while updating another branch.

* resolve markdownlint-cli2 config path properly
* ensure mjs files are included in eslint (tsconfig)
* avoid markdownlint-cli2 from processing node_modules from packages by moving dev deps to root
@jcfranco jcfranco changed the title chore(linting): fix lint-staged not finding markdownlint-cli2 config chore(linting): fix lint-staged errors Apr 8, 2025
@jcfranco jcfranco merged commit a705126 into dev Apr 8, 2025
14 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-lint-staged-not-finding-markdownlint-cli2-config branch April 8, 2025 05:55
@github-actions github-actions Bot added this to the 2025-04-29 - Apr Milestone milestone Apr 8, 2025
benelan pushed a commit that referenced this pull request May 14, 2025
**Related Issue:** N/A  

## Summary  

Fixes errors that came up after recent linting-related updates.

### Notes  

* Resolves `markdownlint-cli2` config path properly
* Ensures `.mjs` files are included in ESLint configs (TS-related)
* Prevents `markdownlint-cli2` from processing `node_modules` in
packages by moving dev dependencies to the root
* Adds type annotations to `lint-staged.config.mjs` files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants