Skip to content

fix: remove unused dragging styles#11883

Merged
jcfranco merged 2 commits intodevfrom
dris0000/sortable-classs-fix
Apr 7, 2025
Merged

fix: remove unused dragging styles#11883
jcfranco merged 2 commits intodevfrom
dris0000/sortable-classs-fix

Conversation

@driskull
Copy link
Copy Markdown
Member

@driskull driskull commented Apr 7, 2025

Related Issue: #11871

Summary

  • In FF, the overflow:hidden on the chosen class was causing the drag and drop to break
  • In this PR, unnecessary styles are removed in order to prevent the breakage and any future breakage
  • No tests are present because our testing is chromium based

@github-actions github-actions Bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Apr 7, 2025
@driskull driskull marked this pull request as ready for review April 7, 2025 17:08
@jcfranco jcfranco changed the title fix: remove unused dragging styles fix: remove unused dragging styles (Firefox) Apr 7, 2025
@jcfranco jcfranco changed the title fix: remove unused dragging styles (Firefox) fix: remove unused dragging styles Apr 7, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Apr 7, 2025
@jcfranco
Copy link
Copy Markdown
Member

jcfranco commented Apr 7, 2025

Confirmed w/ @benelan that this needs to land on dev before proceeding with the hotfix release.

@jcfranco jcfranco merged commit 5827513 into dev Apr 7, 2025
21 checks passed
@jcfranco jcfranco deleted the dris0000/sortable-classs-fix branch April 7, 2025 21:23
@github-actions github-actions Bot added this to the 2025-04-29 - Apr Milestone milestone Apr 7, 2025
jcfranco pushed a commit that referenced this pull request Apr 7, 2025
**Related Issue:** #11871

## Summary

- In FF, the `overflow:hidden` on the chosen class was causing the drag
and drop to break
- In this PR, unnecessary styles are removed in order to prevent the
breakage and any future breakage
- No tests are present because our testing is chromium based
jcfranco added a commit that referenced this pull request Apr 7, 2025
**Related Issue:** #11871

## Summary

- In FF, the `overflow:hidden` on the chosen class was causing the drag
and drop to break
- In this PR, unnecessary styles are removed in order to prevent the
breakage and any future breakage
- No tests are present because our testing is chromium based

Co-authored-by: Matt Driscoll <mdriscoll@esri.com>
driskull added a commit that referenced this pull request Aug 4, 2025
…th the drag handle menu open (#12611)

**Related Issue:** #12204

## Summary

- restores CSS we had removed to handle a firefox bug
- see #11883
benelan pushed a commit that referenced this pull request Sep 16, 2025
…th the drag handle menu open (#12611)

**Related Issue:** #12204

## Summary

- restores CSS we had removed to handle a firefox bug
- see #11883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants