Skip to content

docs: update 3rd party licenses#11853

Closed
calcite-admin wants to merge 1 commit intodevfrom
ci/update-3rd-party-licenses
Closed

docs: update 3rd party licenses#11853
calcite-admin wants to merge 1 commit intodevfrom
ci/update-3rd-party-licenses

Conversation

@calcite-admin
Copy link
Copy Markdown
Contributor

This PR was automatically generated by the update-licenses GitHub action

@calcite-admin calcite-admin requested a review from benelan as a code owner April 3, 2025 00:26
@calcite-admin calcite-admin added docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing. labels Apr 3, 2025
@calcite-admin calcite-admin requested a review from jcfranco as a code owner April 3, 2025 00:26
@jcfranco
Copy link
Copy Markdown
Member

jcfranco commented Apr 3, 2025

Action's looking good!

Copy link
Copy Markdown
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... it looks like the license updates are being formatted. I thought that was handled in #11640, but something might be missing.

@jcfranco
Copy link
Copy Markdown
Member

jcfranco commented Apr 3, 2025

Closing since this only includes formatting changes, which we want to avoid. I'll follow-up on the formatting exception.

@jcfranco jcfranco closed this Apr 3, 2025
@benelan
Copy link
Copy Markdown
Contributor

benelan commented Apr 3, 2025

Closing since this only includes formatting changes, which we want to avoid. I'll follow-up on the formatting exception.

Looks like it's a code issue in the action itself. I think my changes in this commit will fix it: benelan/contributors-readme-action@c26b918

I'll create a PR to switch which branch of my fork our workflow points to.

Edit: #11858

benelan added a commit that referenced this pull request Apr 3, 2025
**Related Issue:** #11853

## Summary

I removed hardcoded tabs from the contributors action, which should fix
the formatting related pull requests.

ref: benelan/contributors-readme-action@c26b918
@jcfranco
Copy link
Copy Markdown
Member

jcfranco commented Apr 4, 2025

Awesome!

I'll follow-up on the formatting exception.

#11867

benelan added a commit that referenced this pull request May 14, 2025
**Related Issue:** #11853

## Summary

I removed hardcoded tabs from the contributors action, which should fix
the formatting related pull requests.

ref: benelan/contributors-readme-action@c26b918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants