Skip to content

ci: move 3rd party license generation to scheduled workflow#11811

Merged
benelan merged 3 commits intodevfrom
benelan/fix-release-error
Mar 31, 2025
Merged

ci: move 3rd party license generation to scheduled workflow#11811
benelan merged 3 commits intodevfrom
benelan/fix-release-error

Conversation

@benelan
Copy link
Copy Markdown
Contributor

@benelan benelan commented Mar 26, 2025

Related Issue: #11640

Summary

Apparently generate-license-file installs our packages locally somewhere in order to generate the 3rd party licenses. The licenses script uses the version in package.json, so running it before publishing causes the following error, since the version doesn't exist yet:

Error: Command failed: npm install --no-workspaces
npm error code ETARGET
npm error notarget No matching version found for @esri/calcite-components@3.1.0.
npm error notarget In most cases you or one of your dependencies are requesting
npm error notarget a package version that doesn't exist.

This moves the 3rd party license generation to the scheduled workflow. A pull request will be created with any licensing changes.

@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Mar 26, 2025
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Mar 26, 2025
@jcfranco
Copy link
Copy Markdown
Member

@benelan Good catch. Should we set up an action that updates the 3rd-party license files on a schedule? cc @geospatialem

@benelan
Copy link
Copy Markdown
Contributor Author

benelan commented Mar 31, 2025

Added the scheduled run to this PR

@benelan benelan changed the title ci: remove 3rd party license generation from release pipeline ci: move 3rd party license generation to scheduled workflow Mar 31, 2025
@benelan benelan merged commit 2a3b44a into dev Mar 31, 2025
16 checks passed
@benelan benelan deleted the benelan/fix-release-error branch March 31, 2025 22:51
@github-actions github-actions Bot added this to the 2025-04-29 - Apr Milestone milestone Mar 31, 2025
@jcfranco
Copy link
Copy Markdown
Member

Added the scheduled run to this PR

Awesome, thanks!

benelan added a commit that referenced this pull request May 14, 2025
**Related Issue:** #11640

## Summary

Apparently [`generate-license-file`](https://www.npmjs.com/package/generate-license-file)
installs our packages locally somewhere in order to generate the 3rd
party licenses. The licenses script uses the version in `package.json`,
so running it before publishing causes the following [error], since the
version doesn't exist yet:

```text
Error: Command failed: npm install --no-workspaces
npm error code ETARGET
npm error notarget No matching version found for @esri/calcite-components@3.1.0.
npm error notarget In most cases you or one of your dependencies are requesting
npm error notarget a package version that doesn't exist.
```

This moves the 3rd party license generation to the scheduled workflow. A
pull request will be created with any licensing changes.

[error]: https://github.com/Esri/calcite-design-system/actions/runs/14076068483/job/39419195501#step:5:1288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants