refactor(tabs): use tag selector#11778
Merged
aPreciado88 merged 1 commit intoaPreciado88/7180-add-tabs-design-tokensfrom Mar 21, 2025
Merged
refactor(tabs): use tag selector#11778aPreciado88 merged 1 commit intoaPreciado88/7180-add-tabs-design-tokensfrom
aPreciado88 merged 1 commit intoaPreciado88/7180-add-tabs-design-tokensfrom
Conversation
Member
|
Sorry for the delay. Can you revert this? We use class selectors to keep tests stable when the component HTML changes. The names can end up being redundant, so I get why it looked safe to remove. I thought this was already part of our conventions, but I couldn’t find a reference. I’ll add a note to our conventions. |
Contributor
|
@jcfranco I reverted this change in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Use tag selector for themed e2e tests