Skip to content

fix(dialog, modal, popover, sheet): fixes an issue that caused extra containers to be lost after internal trap updates#11556

Merged
jcfranco merged 1 commit intodevfrom
jcfranco/11523-fix-issue-causing-extra-focus-trap-container-reset
Feb 14, 2025
Merged

fix(dialog, modal, popover, sheet): fixes an issue that caused extra containers to be lost after internal trap updates#11556
jcfranco merged 1 commit intodevfrom
jcfranco/11523-fix-issue-causing-extra-focus-trap-container-reset

Conversation

@jcfranco
Copy link
Copy Markdown
Member

@jcfranco jcfranco commented Feb 14, 2025 •
edited
Loading

Related Issue: #11523

Summary

#11548 missed calling the internal update focus trap method, using the public method instead, which clears user-specified extraContainers.

@jcfranco
fix(dialog, modal, popover, sheet): fixes an issue that caused extra …
2f8e4ef 
…containers to be lost after internal trap updates
@github-actions github-actions Bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 14, 2025
@jcfranco jcfranco requested review from benelan and driskull February 14, 2025 18:47
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Feb 14, 2025
driskull
driskull approved these changes Feb 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Any need to add a test for this?

@jcfranco
Copy link
Copy Markdown
Member Author

jcfranco commented Feb 14, 2025

Yes. I'm aiming to start adding controller tests soon with #11305. We might also need a focusTrap test helper, right?

@jcfranco
Copy link
Copy Markdown
Member Author

jcfranco commented Feb 14, 2025

We might also need a focusTrap test helper, right?

Created #11558 for this.

@jcfranco jcfranco merged commit 455cb5a into dev Feb 14, 2025
@jcfranco jcfranco deleted the jcfranco/11523-fix-issue-causing-extra-focus-trap-container-reset branch February 14, 2025 19:22
@github-actions github-actions Bot added this to the 2025-02-25 - Feb Milestone milestone Feb 14, 2025
benelan pushed a commit that referenced this pull request Feb 14, 2025
@jcfranco @benelan
fix(dialog, modal, popover, sheet): fixes an issue that caused extra …
a408ceb 
…containers to be lost after internal trap updates (#11556)

**Related Issue:** #11523 

## Summary

#11548 missed calling
the internal update focus trap method, using the public method instead,
which clears user-specified `extraContainers`.
benelan pushed a commit that referenced this pull request Feb 14, 2025
@jcfranco @benelan
fix(dialog, modal, popover, sheet): fixes an issue that caused extra …
083e8dc 
…containers to be lost after internal trap updates (#11556)

**Related Issue:** #11523 

## Summary

#11548 missed calling
the internal update focus trap method, using the public method instead,
which clears user-specified `extraContainers`.
@calcite-admin calcite-admin mentioned this pull request Feb 14, 2025
Merged
benelan pushed a commit that referenced this pull request Feb 14, 2025
@calcite-admin
chore: release main (#11561)
78f3543 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 3.0.2</summary>

##
[3.0.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.1...@esri/calcite-components@3.0.2)
(2025-02-14)


### Bug Fixes

* **dialog, modal, popover, sheet:** Fixes an issue that caused extra
containers to be lost after internal trap updates
([#11556](#11556))
([083e8dc](083e8dc))
</details>

<details><summary>@esri/calcite-components-react: 3.0.2</summary>

##
[3.0.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.1...@esri/calcite-components-react@3.0.2)
(2025-02-14)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.1 to 3.0.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
benelan pushed a commit that referenced this pull request Feb 14, 2025
@calcite-admin @benelan
chore: release main (#11561)
e3fb969 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 3.0.2</summary>

[3.0.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.1...@esri/calcite-components@3.0.2)
(2025-02-14)

* **dialog, modal, popover, sheet:** Fixes an issue that caused extra
containers to be lost after internal trap updates
([#11556](#11556))
([083e8dc](083e8dc))
</details>

<details><summary>@esri/calcite-components-react: 3.0.2</summary>

[3.0.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.1...@esri/calcite-components-react@3.0.2)
(2025-02-14)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.1 to 3.0.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@benelan benelan mentioned this pull request Feb 14, 2025
Merged
benelan added a commit that referenced this pull request Feb 14, 2025
@benelan @calcite-admin
chore: release main (#11561)
c908edb 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 3.0.2</summary>


[3.0.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.1...@esri/calcite-components@3.0.2)
(2025-02-14)

* **dialog, modal, popover, sheet:** Fixes an issue that caused extra
containers to be lost after internal trap updates
([#11556](#11556))
([083e8dc](083e8dc))
</details>

<details><summary>@esri/calcite-components-react: 3.0.2</summary>


[3.0.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.1...@esri/calcite-components-react@3.0.2)
(2025-02-14)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.1 to 3.0.2 </details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
benelan added a commit that referenced this pull request Feb 17, 2025
@benelan
Merge remote-tracking branch 'origin/dev' into 6646-advanced-table
542ed9a 
* origin/dev: (171 commits)
  chore(tip-manager): drop empty spec test (#11568)
  chore: release next
  feat(chip): enhance component's interactivity states (#11538)
  chore: release next
  fix(tooltip): close tooltips on prevented pointer move events (#11557)
  chore: release main (#11561)
  chore: release next
  revert: build(deps): update arcgis to ^4.33.0-next.13 (#11539) (#11559)
  fix(dialog, modal, popover, sheet): fixes an issue that caused extra containers to be lost after internal trap updates (#11556)
  chore: release main (#11551)
  build(deps): update arcgis to ^4.33.0-next.13 (#11539)
  chore: release next
  fix(input-date-picker): allow navigating between months using chevron actions in Safari (#11547)
  chore: release next
  fix(dialog, modal, sheet): preserve focus-trap extra containers across internal trap updates (#11548)
  chore: release next
  feat(segmented-control-item): enhance component's interactivity states (#11477)
  chore: release next
  refactor: drop deprecated loadable component utilities (#11479)
  docs: link to package readmes from root readme (#11531)
  ...
benelan added a commit that referenced this pull request Feb 18, 2025
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/cleanup-cc-readme
31e74e0 
* origin/dev: (27 commits)
  build(deps): update eslint (#11487)
  build(deps): update arcgis to ^4.32.0-next.136 (#11542)
  build(deps): update dependency postcss to v8.5.2 (#11553)
  build(deps): update dependency turbo to v2.4.2 (#11554)
  build: update browserslist db (#11571)
  build(deps): update dependency rollup to v4.34.7 (#11572)
  chore(tip-manager): drop empty spec test (#11568)
  chore: release next
  feat(chip): enhance component's interactivity states (#11538)
  chore: release next
  fix(tooltip): close tooltips on prevented pointer move events (#11557)
  chore: release main (#11561)
  chore: release next
  revert: build(deps): update arcgis to ^4.33.0-next.13 (#11539) (#11559)
  fix(dialog, modal, popover, sheet): fixes an issue that caused extra containers to be lost after internal trap updates (#11556)
  chore: release main (#11551)
  build(deps): update arcgis to ^4.33.0-next.13 (#11539)
  chore: release next
  fix(input-date-picker): allow navigating between months using chevron actions in Safari (#11547)
  chore: release next
  ...
benelan added a commit that referenced this pull request Mar 26, 2025
@benelan @calcite-admin
chore: release main (#11561)
a8e458e 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 3.0.2</summary>


[3.0.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.1...@esri/calcite-components@3.0.2)
(2025-02-14)

* **dialog, modal, popover, sheet:** Fixes an issue that caused extra
containers to be lost after internal trap updates
([#11556](#11556))
([083e8dc](083e8dc))
</details>

<details><summary>@esri/calcite-components-react: 3.0.2</summary>


[3.0.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.1...@esri/calcite-components-react@3.0.2)
(2025-02-14)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.1 to 3.0.2 </details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driskull driskull driskull approved these changes

@benelan benelan Awaiting requested review from benelan

Assignees

@jcfranco jcfranco

Labels

bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Milestone

2025-02-25 - Feb Milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcfranco @driskull