Skip to content

fix(tabs): redisplay close button when more than one tab is closable#11492

Merged
josercarcamo merged 15 commits intodevfrom
josercarcamo/10183-redisplay-tab-x
Mar 4, 2025
Merged

fix(tabs): redisplay close button when more than one tab is closable#11492
josercarcamo merged 15 commits intodevfrom
josercarcamo/10183-redisplay-tab-x

Conversation

@josercarcamo
Copy link
Copy Markdown
Contributor

@josercarcamo josercarcamo commented Feb 7, 2025

Related Issue: #10183

Summary

Redisplays x when > 1 closable tab is added programmatically.

@github-actions github-actions Bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 7, 2025
@josercarcamo josercarcamo added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 7, 2025
@josercarcamo josercarcamo added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 7, 2025
jcfranco
jcfranco requested changes Feb 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, @josercarcamo! One more pass, and I think we can land this.

We'll still need to handle the case where closed tab-titles are restored via the close prop being updated (i.e., items are closed via prop only). This can be done in a follow-up PR.

Comment thread packages/calcite-components/src/components/tab-nav/tab-nav.tsx Outdated
Comment thread packages/calcite-components/src/components/tab-nav/tab-nav.tsx Outdated
*
* @private
*/
firstTabClosable = false;
Copy link
Copy Markdown
Member

@jcfranco jcfranco Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would renaming this private prop to something like lastClosableTabWasClosed help avoid the comment? Making the prop private could also remove the JSDoc tag if we need the comment.

Copy link
Copy Markdown
Contributor Author

@josercarcamo josercarcamo Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should devise another name because lastClosableTabWasClosed is kind of long and not specific. Also, I only added to tag because other properties have tags. I can remove it and just make the property private.

Copy link
Copy Markdown
Member

@jcfranco jcfranco Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, as long as it's specific and helps remove the comment. IMO, maintainability outweighs length due to the variable's scope, but I hear ya.

Comment thread packages/calcite-components/src/components/tab-nav/tab-nav.tsx Outdated
*
* @private
*/
firstTabClosable = false;
Copy link
Copy Markdown
Member

@jcfranco jcfranco Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved to the private props region.

Comment thread packages/calcite-components/src/components/tabs/tabs.e2e.ts Outdated
Comment thread packages/calcite-components/src/components/tabs/tabs.e2e.ts Outdated
Comment thread packages/calcite-components/src/components/tab-nav/tab-nav.tsx Outdated
this.intersectionObserver?.observe(child);
});
if (slottedElements.length > 1 && this.firstTabClosable) {
(slottedElements[0] as TabTitle["el"]).closable = true;
Copy link
Copy Markdown
Member

@jcfranco jcfranco Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to check for closable=false to determine which tab-title should be updated instead of assuming it's the first one (e.g., if the first 4 out of 5 are closed, then a new tab and tab-title are added). Also, should firstTabClosable be reset here?

@josercarcamo josercarcamo added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 12, 2025
@josercarcamo josercarcamo added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 12, 2025
@josercarcamo
Copy link
Copy Markdown
Contributor Author

josercarcamo commented Feb 12, 2025

@jcfranco one more review please.

@jcfranco jcfranco changed the title fix(tabs): x redisplays when > 1 closable tab fix(tabs): redisplay close button when more than one tab is closable Feb 21, 2025
jcfranco
jcfranco approved these changes Feb 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some additional comments, but this LGTM!

✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️
✖️📑✖️✖️✖️📑✖️✖️📑📑✖️✖️📑📑📑✖️✖️📑📑📑✖️📑📑📑📑✖️📑✖️
✖️📑📑✖️✖️📑✖️📑✖️✖️📑✖️✖️📑✖️✖️📑✖️✖️✖️✖️📑✖️✖️✖️✖️📑✖️
✖️📑✖️📑✖️📑✖️📑✖️✖️📑✖️✖️📑✖️✖️📑✖️✖️✖️✖️📑📑📑✖️✖️📑✖️
✖️📑✖️✖️📑📑✖️📑✖️✖️📑✖️✖️📑✖️✖️📑✖️✖️✖️✖️📑✖️✖️✖️✖️✖️✖️
✖️📑✖️✖️✖️📑✖️✖️📑📑✖️✖️📑📑📑✖️✖️📑📑📑✖️📑📑📑📑✖️📑✖️
✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️✖️

Comment thread packages/calcite-components/src/components/tab-nav/tab-nav.tsx Outdated
this.intersectionObserver?.disconnect();

const slottedElements = slotChangeGetAssignedElements(event, "calcite-tab-title");
const slottedElements = slotChangeGetAssignedElements<TabTitle["el"]>(
Copy link
Copy Markdown
Member

@jcfranco jcfranco Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could replace slottedElements with tabTitles directly to simplify.

Comment thread packages/calcite-components/src/components/tab-nav/tab-nav.tsx Outdated
slottedElements.forEach((child) => {
this.intersectionObserver?.observe(child);
});
const visibleTabTitlesIndices = this.visibleTabTitlesIndices;
Copy link
Copy Markdown
Member

@jcfranco jcfranco Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could reuse slottedElements/tabTitles and eliminate one extra DOM query by adding a function that returns the visible tab-title indices from an array of tab-titles.

Comment thread packages/calcite-components/src/components/tabs/tabs.e2e.ts Outdated
expect(selectedTitleOnEmit).toBe("Tab 2 Title");
});

it("should hide x when last closable tab and display x when > 1 closable tabs", async () => {
Copy link
Copy Markdown
Member

@jcfranco jcfranco Feb 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For extra coverage, could you update or add a test for closing tabs 1–3? If adding a new test, could you group them in a describe block?

@jcfranco
Copy link
Copy Markdown
Member

jcfranco commented Feb 22, 2025

@josercarcamo FYI, I updated the PR title to better align with our PR naming conventions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2025

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions Bot added the Stale Issues or pull requests that have not had recent activity. label Mar 3, 2025
@josercarcamo
Merge branch 'josercarcamo/10183-redisplay-tab-x' of github.com:Esri/…
864ac94 
…calcite-design-system into josercarcamo/10183-redisplay-tab-x
@josercarcamo josercarcamo added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 3, 2025
@josercarcamo josercarcamo merged commit 3150fe5 into dev Mar 4, 2025
@josercarcamo josercarcamo deleted the josercarcamo/10183-redisplay-tab-x branch March 4, 2025 00:10
benelan added a commit that referenced this pull request Mar 6, 2025
@benelan
Merge remote-tracking branch 'origin/dev' into 6646-advanced-table
9803d28 
* origin/dev: (80 commits)
  build(deps): update nx monorepo to v20.4.6 (#11662)
  build(deps): update arcgis to ^4.32.7 (#11648)
  build: update browserslist db (#11639)
  build(deps): update eslint (#11670)
  build(deps): update dependency chromatic to v11.26.1 (#11669)
  build(deps): update dependency rollup to v4.34.9 (#11661)
  build(deps): update dependency tsx to v4.19.3 (#11658)
  chore: release next
  docs(text-area): update limitText description (#11672)
  feat(block, block-section): add `expanded` property and deprecate `open` property (#11582)
  feat(list-item, list): add `expanded` property and deprecate `open` property (#11003)
  chore: release next
  fix(tabs): redisplay close button when more than one tab is closable (#11492)
  test(shell-panel): Fix token story set up (#11635)
  chore: set up 3rd-party license generation (#11640)
  build(deps): update dependency happy-dom to v17.1.8 (#11649)
  build(deps): update dependency prettier to v3.5.2 (#11642)
  build(deps): update dependency happy-dom to v17.1.6 (#11641)
  chore: release next
  fix(card-group): Restore default gap spacing (#11638)
  ...
benelan pushed a commit that referenced this pull request Mar 26, 2025
@josercarcamo @benelan
fix(tabs): redisplay close button when more than one tab is closable (#…
ae8064e 
…11492)

**Related Issue:** #10183

## Summary
Redisplays x when > 1 closable tab is added programmatically.
@calcite-admin calcite-admin mentioned this pull request Mar 26, 2025
Merged
benelan added a commit that referenced this pull request Mar 26, 2025
@calcite-admin @github-actions @benelan
chore: release main (#11809)
d5f75fd 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-design-tokens: 3.0.1</summary>

##
[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-design-tokens@3.0.0...@esri/calcite-design-tokens@3.0.1)
(2025-03-26)


### Bug Fixes

* Allow global focus color token to inherit fallback value
([#11711](#11711))
([a732c8d](a732c8d))

</details>

<details><summary>@esri/calcite-ui-icons: 4.1.0</summary>

##
[4.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@4.0.0...@esri/calcite-ui-icons@4.1.0)
(2025-03-26)


### Features

* Add browser join and browser plus
([#11779](#11779))
([8f69b2d](8f69b2d))
* Update check
([#11799](#11799))
([5058939](5058939))
* Add language-2
([#11739](#11739))
([989df67](989df67))

</details>

<details><summary>@esri/eslint-plugin-calcite-components:
2.0.1</summary>

##
[2.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@2.0.0...@esri/eslint-plugin-calcite-components@2.0.1)
(2025-03-26)

**Note:** Version bump only for package
@esri/eslint-plugin-calcite-components

</details>

<details><summary>@esri/calcite-components: 3.1.0</summary>

##
[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.3...@esri/calcite-components@3.1.0)
(2025-03-26)


### Features

* **accordion:** Add new component tokens and deprecate old tokens
([#11390](#11390))
([fdf3e61](fdf3e61))
* **action:** Enhance component's interactivity states
([#11478](#11478))
([aad98df](aad98df))
* **block, block-section:** Add `expanded` property and deprecate `open`
property
([#11582](#11582))
([999f532](999f532))
* **button:** Enhance component's interactivity states
([#11590](#11590))
([23a62ca](23a62ca))
* **chip:** Deprecate `pressed` in favor of `press`
([#11389](#11389))
([c905f9f](c905f9f))
* **chip:** Enhance component's interactivity states
([#11538](#11538))
([8db5697](8db5697))
* **combobox-item:** Add component tokens
([#11645](#11645))
([9cbd155](9cbd155))
* **combobox-item:** Update idle icons
([#11801](#11801))
([034f430](034f430))
* **combobox-item:** Update interactive state
([#11647](#11647))
([19d7c43](19d7c43))
* **combobox-item:** Update selection icons
([#11726](#11726))
([723fd22](723fd22))
* **combobox, combobox-item-group:** Add component tokens
([#11623](#11623))
([8215314](8215314))
* **dropdown, dropdown-item, dropdown-group:** Add component tokens
([#11465](#11465))
([85f9378](85f9378))
* **dropdown:** Add `offsetDistance` and `offsetSkidding` properties
([#11614](#11614))
([3381040](3381040))
* **fab:** Add component tokens
([#11723](#11723))
([d436514](d436514))
* **flow-item:** Expose `FlowItemLike` type
([#11791](#11791))
([28c7522](28c7522))
* **list-item, list:** Add `expanded` property and deprecate `open`
property
([#11003](#11003))
([c80c44c](c80c44c))
* **rating:** Enhance component's interactivity states
([#11469](#11469))
([11d83f6](11d83f6))
* **segmented-control-item:** Enhance component's interactivity states
([#11477](#11477))
([f025330](f025330))
* **split-button:** Make downloadable and linkable
([#11520](#11520))
([fb3e1dc](fb3e1dc))
* **tab-title:** Enhance component's interactivity states
([#11493](#11493))
([88a5260](88a5260))


### Bug Fixes

* **card-group:** Restore default gap spacing
([#11638](#11638))
([a554598](a554598))
* **dropdown-group:** Fix error caused by early removal
([#11612](#11612))
([2dcef25](2dcef25))
* **panel:** Apply custom styles correctly to header actions
([#11495](#11495))
([5e84892](5e84892))
* Set floating-ui elements max size set to the view
([#11577](#11577))
([b3ffd7f](b3ffd7f))
* **tabs:** Redisplay close button when more than one tab is closable
([#11492](#11492))
([ae8064e](ae8064e))
* **text-area:** Fix error caused by internal measuring on disconnect
([#11751](#11751))
([810f79e](810f79e))
* **tooltip:** Close tooltip when hovering out of an iframe
([#11600](#11600))
([93a5692](93a5692))
* **tooltip:** Do not open after the pointer has moved off of the
reference element
([#11599](#11599))
([33cadc8](33cadc8))

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 4.1.0-next.3 to 4.1.0
  * devDependencies
    * @esri/calcite-design-tokens bumped from 3.0.1-next.4 to 3.0.1
* @esri/eslint-plugin-calcite-components bumped from 2.0.1-next.2 to
2.0.1
</details>

<details><summary>@esri/calcite-components-react: 3.1.0</summary>

##
[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.3...@esri/calcite-components-react@3.1.0)
(2025-03-26)

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.1.0-next.31 to 3.1.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
@benelan benelan mentioned this pull request Mar 26, 2025
Merged
benelan added a commit that referenced this pull request Mar 26, 2025
@calcite-admin @github-actions @benelan
chore: release main (#11809)
715cf93 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-design-tokens: 3.0.1</summary>

[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-design-tokens@3.0.0...@esri/calcite-design-tokens@3.0.1)
(2025-03-26)

* Allow global focus color token to inherit fallback value
([#11711](#11711))
([a732c8d](a732c8d))

</details>

<details><summary>@esri/calcite-ui-icons: 4.1.0</summary>

[4.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@4.0.0...@esri/calcite-ui-icons@4.1.0)
(2025-03-26)

* Add browser join and browser plus
([#11779](#11779))
([8f69b2d](8f69b2d))
* Update check
([#11799](#11799))
([5058939](5058939))
* Add language-2
([#11739](#11739))
([989df67](989df67))

</details>

<details><summary>@esri/eslint-plugin-calcite-components:
2.0.1</summary>

[2.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@2.0.0...@esri/eslint-plugin-calcite-components@2.0.1)
(2025-03-26)

**Note:** Version bump only for package
@esri/eslint-plugin-calcite-components

</details>

<details><summary>@esri/calcite-components: 3.1.0</summary>

[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.3...@esri/calcite-components@3.1.0)
(2025-03-26)

* **accordion:** Add new component tokens and deprecate old tokens
([#11390](#11390))
([fdf3e61](fdf3e61))
* **action:** Enhance component's interactivity states
([#11478](#11478))
([aad98df](aad98df))
* **block, block-section:** Add `expanded` property and deprecate `open`
property
([#11582](#11582))
([999f532](999f532))
* **button:** Enhance component's interactivity states
([#11590](#11590))
([23a62ca](23a62ca))
* **chip:** Deprecate `pressed` in favor of `press`
([#11389](#11389))
([c905f9f](c905f9f))
* **chip:** Enhance component's interactivity states
([#11538](#11538))
([8db5697](8db5697))
* **combobox-item:** Add component tokens
([#11645](#11645))
([9cbd155](9cbd155))
* **combobox-item:** Update idle icons
([#11801](#11801))
([034f430](034f430))
* **combobox-item:** Update interactive state
([#11647](#11647))
([19d7c43](19d7c43))
* **combobox-item:** Update selection icons
([#11726](#11726))
([723fd22](723fd22))
* **combobox, combobox-item-group:** Add component tokens
([#11623](#11623))
([8215314](8215314))
* **dropdown, dropdown-item, dropdown-group:** Add component tokens
([#11465](#11465))
([85f9378](85f9378))
* **dropdown:** Add `offsetDistance` and `offsetSkidding` properties
([#11614](#11614))
([3381040](3381040))
* **fab:** Add component tokens
([#11723](#11723))
([d436514](d436514))
* **flow-item:** Expose `FlowItemLike` type
([#11791](#11791))
([28c7522](28c7522))
* **list-item, list:** Add `expanded` property and deprecate `open`
property
([#11003](#11003))
([c80c44c](c80c44c))
* **rating:** Enhance component's interactivity states
([#11469](#11469))
([11d83f6](11d83f6))
* **segmented-control-item:** Enhance component's interactivity states
([#11477](#11477))
([f025330](f025330))
* **split-button:** Make downloadable and linkable
([#11520](#11520))
([fb3e1dc](fb3e1dc))
* **tab-title:** Enhance component's interactivity states
([#11493](#11493))
([88a5260](88a5260))

* **card-group:** Restore default gap spacing
([#11638](#11638))
([a554598](a554598))
* **dropdown-group:** Fix error caused by early removal
([#11612](#11612))
([2dcef25](2dcef25))
* **panel:** Apply custom styles correctly to header actions
([#11495](#11495))
([5e84892](5e84892))
* Set floating-ui elements max size set to the view
([#11577](#11577))
([b3ffd7f](b3ffd7f))
* **tabs:** Redisplay close button when more than one tab is closable
([#11492](#11492))
([ae8064e](ae8064e))
* **text-area:** Fix error caused by internal measuring on disconnect
([#11751](#11751))
([810f79e](810f79e))
* **tooltip:** Close tooltip when hovering out of an iframe
([#11600](#11600))
([93a5692](93a5692))
* **tooltip:** Do not open after the pointer has moved off of the
reference element
([#11599](#11599))
([33cadc8](33cadc8))

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 4.1.0-next.3 to 4.1.0
  * devDependencies
    * @esri/calcite-design-tokens bumped from 3.0.1-next.4 to 3.0.1
* @esri/eslint-plugin-calcite-components bumped from 2.0.1-next.2 to
2.0.1
</details>

<details><summary>@esri/calcite-components-react: 3.1.0</summary>

[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.3...@esri/calcite-components-react@3.1.0)
(2025-03-26)

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.1.0-next.31 to 3.1.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
benelan added a commit that referenced this pull request Mar 26, 2025
@benelan @calcite-admin @github-actions
chore: cherry pick release commit from main (#11813)
0d141c6 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-design-tokens: 3.0.1</summary>


[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-design-tokens@3.0.0...@esri/calcite-design-tokens@3.0.1)
(2025-03-26)

* Allow global focus color token to inherit fallback value
([#11711](#11711))

([a732c8d](a732c8d))

</details>

<details><summary>@esri/calcite-ui-icons: 4.1.0</summary>


[4.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@4.0.0...@esri/calcite-ui-icons@4.1.0)
(2025-03-26)

* Add browser join and browser plus
([#11779](#11779))

([8f69b2d](8f69b2d))
* Update check
([#11799](#11799))

([5058939](5058939))
* Add language-2
([#11739](#11739))

([989df67](989df67))

</details>

<details><summary>@esri/eslint-plugin-calcite-components:
2.0.1</summary>


[2.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@2.0.0...@esri/eslint-plugin-calcite-components@2.0.1)
(2025-03-26)

**Note:** Version bump only for package
@esri/eslint-plugin-calcite-components

</details>

<details><summary>@esri/calcite-components: 3.1.0</summary>


[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.3...@esri/calcite-components@3.1.0)
(2025-03-26)

* **accordion:** Add new component tokens and deprecate old tokens
([#11390](#11390))

([fdf3e61](fdf3e61))
* **action:** Enhance component's interactivity states
([#11478](#11478))

([aad98df](aad98df))
* **block, block-section:** Add `expanded` property and deprecate `open`
property
([#11582](#11582))

([999f532](999f532))
* **button:** Enhance component's interactivity states
([#11590](#11590))

([23a62ca](23a62ca))
* **chip:** Deprecate `pressed` in favor of `press`
([#11389](#11389))

([c905f9f](c905f9f))
* **chip:** Enhance component's interactivity states
([#11538](#11538))

([8db5697](8db5697))
* **combobox-item:** Add component tokens
([#11645](#11645))

([9cbd155](9cbd155))
* **combobox-item:** Update idle icons
([#11801](#11801))

([034f430](034f430))
* **combobox-item:** Update interactive state
([#11647](#11647))

([19d7c43](19d7c43))
* **combobox-item:** Update selection icons
([#11726](#11726))

([723fd22](723fd22))
* **combobox, combobox-item-group:** Add component tokens
([#11623](#11623))

([8215314](8215314))
* **dropdown, dropdown-item, dropdown-group:** Add component tokens
([#11465](#11465))

([85f9378](85f9378))
* **dropdown:** Add `offsetDistance` and `offsetSkidding` properties
([#11614](#11614))

([3381040](3381040))
* **fab:** Add component tokens
([#11723](#11723))

([d436514](d436514))
* **flow-item:** Expose `FlowItemLike` type
([#11791](#11791))

([28c7522](28c7522))
* **list-item, list:** Add `expanded` property and deprecate `open`
property
([#11003](#11003))

([c80c44c](c80c44c))
* **rating:** Enhance component's interactivity states
([#11469](#11469))

([11d83f6](11d83f6))
* **segmented-control-item:** Enhance component's interactivity states
([#11477](#11477))

([f025330](f025330))
* **split-button:** Make downloadable and linkable
([#11520](#11520))

([fb3e1dc](fb3e1dc))
* **tab-title:** Enhance component's interactivity states
([#11493](#11493))

([88a5260](88a5260))

* **card-group:** Restore default gap spacing
([#11638](#11638))

([a554598](a554598))
* **dropdown-group:** Fix error caused by early removal
([#11612](#11612))

([2dcef25](2dcef25))
* **panel:** Apply custom styles correctly to header actions
([#11495](#11495))

([5e84892](5e84892))
* Set floating-ui elements max size set to the view
([#11577](#11577))

([b3ffd7f](b3ffd7f))
* **tabs:** Redisplay close button when more than one tab is closable
([#11492](#11492))

([ae8064e](ae8064e))
* **text-area:** Fix error caused by internal measuring on disconnect
([#11751](#11751))

([810f79e](810f79e))
* **tooltip:** Close tooltip when hovering out of an iframe
([#11600](#11600))

([93a5692](93a5692))
* **tooltip:** Do not open after the pointer has moved off of the
reference element
([#11599](#11599))

([33cadc8](33cadc8))

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 4.1.0-next.3 to 4.1.0
  * devDependencies
    * @esri/calcite-design-tokens bumped from 3.0.1-next.4 to 3.0.1
* @esri/eslint-plugin-calcite-components bumped from 2.0.1-next.2 to
2.0.1
</details>

<details><summary>@esri/calcite-components-react: 3.1.0</summary>


[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.3...@esri/calcite-components-react@3.1.0)
(2025-03-26)

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.1.0-next.31 to 3.1.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot]
<github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@josercarcamo josercarcamo mentioned this pull request Apr 20, 2025
Open
6 tasks
benelan added a commit that referenced this pull request May 14, 2025
@benelan @calcite-admin @github-actions
chore: cherry pick release commit from main (#11813)
23ae1c9 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-design-tokens: 3.0.1</summary>

[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-design-tokens@3.0.0...@esri/calcite-design-tokens@3.0.1)
(2025-03-26)

* Allow global focus color token to inherit fallback value
([#11711](#11711))

([a732c8d](a732c8d))

</details>

<details><summary>@esri/calcite-ui-icons: 4.1.0</summary>

[4.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@4.0.0...@esri/calcite-ui-icons@4.1.0)
(2025-03-26)

* Add browser join and browser plus
([#11779](#11779))

([8f69b2d](8f69b2d))
* Update check
([#11799](#11799))

([5058939](5058939))
* Add language-2
([#11739](#11739))

([989df67](989df67))

</details>

<details><summary>@esri/eslint-plugin-calcite-components:
2.0.1</summary>

[2.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@2.0.0...@esri/eslint-plugin-calcite-components@2.0.1)
(2025-03-26)

**Note:** Version bump only for package
@esri/eslint-plugin-calcite-components

</details>

<details><summary>@esri/calcite-components: 3.1.0</summary>

[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.3...@esri/calcite-components@3.1.0)
(2025-03-26)

* **accordion:** Add new component tokens and deprecate old tokens
([#11390](#11390))

([fdf3e61](fdf3e61))
* **action:** Enhance component's interactivity states
([#11478](#11478))

([aad98df](aad98df))
* **block, block-section:** Add `expanded` property and deprecate `open`
property
([#11582](#11582))

([999f532](999f532))
* **button:** Enhance component's interactivity states
([#11590](#11590))

([23a62ca](23a62ca))
* **chip:** Deprecate `pressed` in favor of `press`
([#11389](#11389))

([c905f9f](c905f9f))
* **chip:** Enhance component's interactivity states
([#11538](#11538))

([8db5697](8db5697))
* **combobox-item:** Add component tokens
([#11645](#11645))

([9cbd155](9cbd155))
* **combobox-item:** Update idle icons
([#11801](#11801))

([034f430](034f430))
* **combobox-item:** Update interactive state
([#11647](#11647))

([19d7c43](19d7c43))
* **combobox-item:** Update selection icons
([#11726](#11726))

([723fd22](723fd22))
* **combobox, combobox-item-group:** Add component tokens
([#11623](#11623))

([8215314](8215314))
* **dropdown, dropdown-item, dropdown-group:** Add component tokens
([#11465](#11465))

([85f9378](85f9378))
* **dropdown:** Add `offsetDistance` and `offsetSkidding` properties
([#11614](#11614))

([3381040](3381040))
* **fab:** Add component tokens
([#11723](#11723))

([d436514](d436514))
* **flow-item:** Expose `FlowItemLike` type
([#11791](#11791))

([28c7522](28c7522))
* **list-item, list:** Add `expanded` property and deprecate `open`
property
([#11003](#11003))

([c80c44c](c80c44c))
* **rating:** Enhance component's interactivity states
([#11469](#11469))

([11d83f6](11d83f6))
* **segmented-control-item:** Enhance component's interactivity states
([#11477](#11477))

([f025330](f025330))
* **split-button:** Make downloadable and linkable
([#11520](#11520))

([fb3e1dc](fb3e1dc))
* **tab-title:** Enhance component's interactivity states
([#11493](#11493))

([88a5260](88a5260))

* **card-group:** Restore default gap spacing
([#11638](#11638))

([a554598](a554598))
* **dropdown-group:** Fix error caused by early removal
([#11612](#11612))

([2dcef25](2dcef25))
* **panel:** Apply custom styles correctly to header actions
([#11495](#11495))

([5e84892](5e84892))
* Set floating-ui elements max size set to the view
([#11577](#11577))

([b3ffd7f](b3ffd7f))
* **tabs:** Redisplay close button when more than one tab is closable
([#11492](#11492))

([ae8064e](ae8064e))
* **text-area:** Fix error caused by internal measuring on disconnect
([#11751](#11751))

([810f79e](810f79e))
* **tooltip:** Close tooltip when hovering out of an iframe
([#11600](#11600))

([93a5692](93a5692))
* **tooltip:** Do not open after the pointer has moved off of the
reference element
([#11599](#11599))

([33cadc8](33cadc8))

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 4.1.0-next.3 to 4.1.0
  * devDependencies
    * @esri/calcite-design-tokens bumped from 3.0.1-next.4 to 3.0.1
* @esri/eslint-plugin-calcite-components bumped from 2.0.1-next.2 to
2.0.1
</details>

<details><summary>@esri/calcite-components-react: 3.1.0</summary>

[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.3...@esri/calcite-components-react@3.1.0)
(2025-03-26)

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.1.0-next.31 to 3.1.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot]
<github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan added a commit that referenced this pull request Sep 16, 2025
@benelan @calcite-admin @github-actions
chore: cherry pick release commit from main (#11813)
cb5284b 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-design-tokens: 3.0.1</summary>

[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-design-tokens@3.0.0...@esri/calcite-design-tokens@3.0.1)
(2025-03-26)

* Allow global focus color token to inherit fallback value
([#11711](#11711))

([a732c8d](a732c8d))

</details>

<details><summary>@esri/calcite-ui-icons: 4.1.0</summary>

[4.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@4.0.0...@esri/calcite-ui-icons@4.1.0)
(2025-03-26)

* Add browser join and browser plus
([#11779](#11779))

([8f69b2d](8f69b2d))
* Update check
([#11799](#11799))

([5058939](5058939))
* Add language-2
([#11739](#11739))

([989df67](989df67))

</details>

<details><summary>@esri/eslint-plugin-calcite-components:
2.0.1</summary>

[2.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@2.0.0...@esri/eslint-plugin-calcite-components@2.0.1)
(2025-03-26)

**Note:** Version bump only for package
@esri/eslint-plugin-calcite-components

</details>

<details><summary>@esri/calcite-components: 3.1.0</summary>

[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.3...@esri/calcite-components@3.1.0)
(2025-03-26)

* **accordion:** Add new component tokens and deprecate old tokens
([#11390](#11390))

([fdf3e61](fdf3e61))
* **action:** Enhance component's interactivity states
([#11478](#11478))

([aad98df](aad98df))
* **block, block-section:** Add `expanded` property and deprecate `open`
property
([#11582](#11582))

([999f532](999f532))
* **button:** Enhance component's interactivity states
([#11590](#11590))

([23a62ca](23a62ca))
* **chip:** Deprecate `pressed` in favor of `press`
([#11389](#11389))

([c905f9f](c905f9f))
* **chip:** Enhance component's interactivity states
([#11538](#11538))

([8db5697](8db5697))
* **combobox-item:** Add component tokens
([#11645](#11645))

([9cbd155](9cbd155))
* **combobox-item:** Update idle icons
([#11801](#11801))

([034f430](034f430))
* **combobox-item:** Update interactive state
([#11647](#11647))

([19d7c43](19d7c43))
* **combobox-item:** Update selection icons
([#11726](#11726))

([723fd22](723fd22))
* **combobox, combobox-item-group:** Add component tokens
([#11623](#11623))

([8215314](8215314))
* **dropdown, dropdown-item, dropdown-group:** Add component tokens
([#11465](#11465))

([85f9378](85f9378))
* **dropdown:** Add `offsetDistance` and `offsetSkidding` properties
([#11614](#11614))

([3381040](3381040))
* **fab:** Add component tokens
([#11723](#11723))

([d436514](d436514))
* **flow-item:** Expose `FlowItemLike` type
([#11791](#11791))

([28c7522](28c7522))
* **list-item, list:** Add `expanded` property and deprecate `open`
property
([#11003](#11003))

([c80c44c](c80c44c))
* **rating:** Enhance component's interactivity states
([#11469](#11469))

([11d83f6](11d83f6))
* **segmented-control-item:** Enhance component's interactivity states
([#11477](#11477))

([f025330](f025330))
* **split-button:** Make downloadable and linkable
([#11520](#11520))

([fb3e1dc](fb3e1dc))
* **tab-title:** Enhance component's interactivity states
([#11493](#11493))

([88a5260](88a5260))

* **card-group:** Restore default gap spacing
([#11638](#11638))

([a554598](a554598))
* **dropdown-group:** Fix error caused by early removal
([#11612](#11612))

([2dcef25](2dcef25))
* **panel:** Apply custom styles correctly to header actions
([#11495](#11495))

([5e84892](5e84892))
* Set floating-ui elements max size set to the view
([#11577](#11577))

([b3ffd7f](b3ffd7f))
* **tabs:** Redisplay close button when more than one tab is closable
([#11492](#11492))

([ae8064e](ae8064e))
* **text-area:** Fix error caused by internal measuring on disconnect
([#11751](#11751))

([810f79e](810f79e))
* **tooltip:** Close tooltip when hovering out of an iframe
([#11600](#11600))

([93a5692](93a5692))
* **tooltip:** Do not open after the pointer has moved off of the
reference element
([#11599](#11599))

([33cadc8](33cadc8))

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 4.1.0-next.3 to 4.1.0
  * devDependencies
    * @esri/calcite-design-tokens bumped from 3.0.1-next.4 to 3.0.1
* @esri/eslint-plugin-calcite-components bumped from 2.0.1-next.2 to
2.0.1
</details>

<details><summary>@esri/calcite-components-react: 3.1.0</summary>

[3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.3...@esri/calcite-components-react@3.1.0)
(2025-03-26)

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.1.0-next.31 to 3.1.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot]
<github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@josercarcamo josercarcamo

Labels

bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.

Projects

None yet

Milestone

2025-03-25 - 3.1.0 Mar Release

Development

Successfully merging this pull request may close these issues.

2 participants

@josercarcamo @jcfranco