chore(stencil): replacing stencil references#11372
Merged
Conversation
…nto dit13711/10889-remove-references-to-stencil
github-actions
Bot
added
the
chore
calcite-admin
added
the
skip visual snapshots
Contributor
Author
|
@jcfranco or @benelan Please let me know if the places where I replaced Stencil with Lit or Vitest, etc is correct. Also there's locations where I put "TODO" comments, These areas are a bit more technical and I'm not sure how many of them are still relevant and of the ones that are, what are we using now? If you guys could give some insight on those I can get them changed or removed where needed. Also also, if you guys know of anywhere else that is missing in this pass of changes please LMK. |
jcfranco
reviewed
Jan 24, 2025
| ``` | ||
|
|
||
| <!-- TODO: Get suggestions for what this should be replaced with --> | ||
|
|
Member
There was a problem hiding this comment.
Any info related to building a component with Lumina should be removed. We could add a link to the internal doc.
Contributor
Author
There was a problem hiding this comment.
What is this referring to specifically? Should this whole "assets" section be removed?
Member
There was a problem hiding this comment.
Yes, assets and anything that is covered by https://qawebgis.esri.com/components/lumina/introduction. We could just link to it.
…nto dit13711/10889-remove-references-to-stencil
benelan
reviewed
Jan 28, 2025
Contributor
benelan
left a comment
benelan
left a comment
There was a problem hiding this comment.
Franco covered most of it but I added some additional comments.
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
…nto dit13711/10889-remove-references-to-stencil
…nto dit13711/10889-remove-references-to-stencil
jcfranco
approved these changes
Jan 31, 2025
| ``` | ||
|
|
||
| <!-- TODO: Get suggestions for what this should be replaced with --> | ||
|
|
Member
There was a problem hiding this comment.
Yes, assets and anything that is covered by https://qawebgis.esri.com/components/lumina/introduction. We could just link to it.
maxpatiiuk
approved these changes
Feb 3, 2025
benelan
approved these changes
Feb 3, 2025
…nto dit13711/10889-remove-references-to-stencil
github-actions
Bot
added this to the
2025-02-06 - 3.0.0 Feb Breaking Change Release milestone
benelan
added a commit
that referenced
this pull request
Feb 8, 2025
**Related Issue:** #10889 ## Summary Removing stale references to Stencil across the repo and replacing where necessary with info on Lit and other tools. --------- Co-authored-by: Ben Elan <no-reply@benelan.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #10889
Summary
Removing stale references to Stencil across the repo and replacing where necessary with info on Lit and other tools.