Skip to content

refactor(tile): remove unused data attributes - #11216

Merged
jcfranco merged 3 commits into
devfrom
jcfranco/tidy-up-tile
Jan 10, 2025
Merged

refactor(tile): remove unused data attributes#11216
jcfranco merged 3 commits into
devfrom
jcfranco/tidy-up-tile

Conversation

@jcfranco

@jcfranco jcfranco commented Jan 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Related Issue: N/A

Summary

✨🧹✨

Note: #11215 should be merged prior to this.

@github-actions github-actions Bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 7, 2025
@jcfranco jcfranco changed the title fix(tile-group): keep selection icon size consistent for large tiles refactor(tile): remove unused data attributes Jan 7, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 7, 2025
@jcfranco
jcfranco requested a review from eriklharper January 7, 2025 23:59
@eriklharper

eriklharper commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note: #11216 should be merged prior to this.

Did you mean to link to #11215 instead?

eriklharper
eriklharper approved these changes Jan 8, 2025
View reviewed changes

@eriklharper eriklharper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attribute removal changes look good to me. Once #11215 merges, this should be good to go! :)

@jcfranco

jcfranco commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Did you mean to link to #11215 instead?

Whoops, yes. 😅 Thanks for the catch! 🎣

@jcfranco
jcfranco marked this pull request as ready for review January 8, 2025 17:56
@github-actions github-actions Bot added the refactor Issues tied to code that needs to be significantly reworked. label Jan 10, 2025
@jcfranco
jcfranco merged commit 4fccea7 into dev Jan 10, 2025
@jcfranco
jcfranco deleted the jcfranco/tidy-up-tile branch January 10, 2025 09:18
benelan pushed a commit that referenced this pull request Feb 8, 2025
@jcfranco @benelan
refactor(tile): remove unused data attributes (#11216)
dc2fd0d 
**Related Issue:** N/A

## Summary

✨🧹✨

**Note**: #11215
should be merged prior to this.
This was referenced Aug 29, 2026
Closed
Merged
jcfranco added a commit that referenced this pull request Aug 31, 2026
@jcfranco
fix(tile): restore top/bottom slot spacing (#15101)
5b6785b 
**Related Issue:** #15100

## Summary

Fixes visual regression introduced in
#11216.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriklharper eriklharper eriklharper approved these changes

Assignees

@jcfranco jcfranco

Labels

bug Bug reports for broken functionality. Issues should include a reproduction of the bug. refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Milestone

2025-02-06 - 3.0.0 Feb Breaking Chang...

Development

Successfully merging this pull request may close these issues.

2 participants

@jcfranco @eriklharper