refactor(autocomplete, input, input-number, input-text): improve types#11121
Merged
refactor(autocomplete, input, input-number, input-text): improve types#11121
Conversation
github-actions
Bot
added
the
enhancement
jcfranco
changed the title
jcfranco
added
the
skip visual snapshots
maxpatiiuk
approved these changes
Dec 20, 2024
| [CSS.inlineChild]: !!this.inlineEditableEl, | ||
| }} | ||
| defaultValue={this.defaultValue} | ||
| disabled={this.disabled ? true : null} |
Member
There was a problem hiding this comment.
does this still need to have ? true : null? is that expected or is it a bug I should fix?
Suggested change
| disabled={this.disabled ? true : null} | |
| disabled={this.disabled} |
Member
Author
There was a problem hiding this comment.
I'll test for that separately to keep this PR focused.
github-actions
Bot
added
the
refactor
maxpatiiuk
approved these changes
Dec 21, 2024
github-actions
Bot
added this to the
2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
This improves existing types to make way for Lumina type enhancements.
Note: this also removes some workarounds related to previous global attribute handling.