Skip to content

fix(dialog, modal, popover, sheet): restore deactivating focus traps on outside click#11058

Merged
jcfranco merged 3 commits intodevfrom
jcfranco/restore-deactivating-focus-traps-on-outside-click
Dec 16, 2024
Merged

fix(dialog, modal, popover, sheet): restore deactivating focus traps on outside click#11058
jcfranco merged 3 commits intodevfrom
jcfranco/restore-deactivating-focus-traps-on-outside-click

Conversation

@jcfranco
Copy link
Copy Markdown
Member

@jcfranco jcfranco commented Dec 14, 2024

Related Issue: #10731

Summary

This addresses an issue where focus-trapping components were unintentionally modified by #9231 to block interaction/focusing via outside clicks.

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

@github-actions github-actions Bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 14, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 14, 2024
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 👍

@jcfranco jcfranco merged commit 472250d into dev Dec 16, 2024
@jcfranco jcfranco deleted the jcfranco/restore-deactivating-focus-traps-on-outside-click branch December 16, 2024 22:42
@github-actions github-actions Bot added this to the 2024-12-17 - Dec Milestone milestone Dec 16, 2024
@jcfranco jcfranco added the no changelog entry Use the commit override to avoid a changelog entry label Dec 16, 2024
benelan pushed a commit that referenced this pull request Feb 8, 2025
…on outside click (#11058)

**Related Issue:** #10731 

## Summary

This addresses an issue where focus-trapping components were
unintentionally modified by
#9231 to block
interaction/focusing via outside clicks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants