Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump React deps to v18 #10691

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 5, 2024

Related Issue: N/A

Summary

🤜💥🤛

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Nov 5, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 5, 2024
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

benelan

This comment was marked as duplicate.

@benelan
Copy link
Member

benelan commented Nov 5, 2024

@jcfranco I just noticed that there are some errors building the react wrapper, do you want me to take a look?

Error: @esri/calcite-components-react:build: src/react-component-lib/createOverlayComponent.tsx(140,13): error TS2322: Type 'PropsWithoutRef<Props> & { forwardedRef: ForwardedRef<OverlayType>; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Overlay> & Readonly<Props>'.
  Type 'PropsWithoutRef<Props> & { forwardedRef: ForwardedRef<OverlayType>; }' is not assignable to type 'Readonly<Props>'.

Error: @esri/calcite-components-react:build: src/react-component-lib/utils/index.tsx(40,27): error TS2345: Argument of type '{ (props: StencilReactExternalProps<PropType, ElementType>, ref: StencilReactForwardedRef<ElementType>): React.JSX.Element; displayName: string; }' is not assignable to parameter of type 'ForwardRefRenderFunction<ElementType, PropsWithoutRef<StencilReactExternalProps<PropType, ElementType>>>'.
  Types of parameters 'props' and 'props' are incompatible.
    Type 'PropsWithoutRef<StencilReactExternalProps<PropType, ElementType>>' is not assignable to type 'StencilReactExternalProps<PropType, ElementType>'.
      Type 'Omit<HTMLAttributes<ElementType>, "style"> & StyleReactProps' is not assignable to type 'StencilReactExternalProps<PropType, ElementType>'.
        Type 'Omit<HTMLAttributes<ElementType>, "style"> & StyleReactProps' is not assignable to type 'PropType'.
          'PropType' could be instantiated with an arbitrary type which could be unrelated to 'Omit<HTMLAttributes<ElementType>, "style"> & StyleReactProps'.

@jcfranco
Copy link
Member Author

jcfranco commented Nov 6, 2024

Thanks for testing, @benelan! Tested w/ #10482 and confirmed that these dep bumps will not be an issue after that lands.

@jcfranco jcfranco added the blocked This issue is blocked by another issue. label Nov 6, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue is blocked by another issue. chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants