Skip to content

fix(action-pad): fix horizontal action group alignment #10359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geospatialem merged 3 commits into from
Sep 25, 2024
Merged

fix(action-pad): fix horizontal action group alignment #10359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cf31a8
fix(action-pad): only add bottom border for vertical layout
Sep 19, 2024
9e3d7d2
text(action-pad): catch action-group layout issue
Sep 19, 2024
52ae736
chore(action-pad): update stories name
alisonailea Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/calcite-components/src/components/action-pad/action-pad.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@
max-inline-size: var(--calcite-action-pad-expanded-max-width, auto);
}

::slotted(calcite-action-group:not(:last-of-type)) {
@apply border-b;
:host([layout="vertical"]) {
::slotted(calcite-action-group:not(:last-of-type)) {
@apply border-b;
}
}

.container {
Expand Down
21 changes: 21 additions & 0 deletions packages/calcite-components/src/components/action-pad/action-pad.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,27 @@ export const simple = (args: ActionPadStoryArgs): string => html`
</calcite-action-pad>
`;

export const withGroups = (): string =>
html`<calcite-action-pad layout="horizontal">
<calcite-action-group>
<calcite-action text="Add" icon="plus" appearance="solid" scale="m"></calcite-action>
<calcite-action text="Save" icon="save" appearance="solid" scale="m"></calcite-action>
</calcite-action-group>
<calcite-action-group>
<calcite-action text="Layers" icon="layers" appearance="solid" scale="m"></calcite-action>
<calcite-action text="Basemaps" icon="layer-basemap" appearance="solid" scale="m"></calcite-action>
</calcite-action-group>
<calcite-tooltip
slot="expand-tooltip"
id="calcite-tooltip-c19274e3-ff3b-6168-ef1e-8a700b056e1c"
role="tooltip"
overlay-positioning="absolute"
placement="auto"
style="visibility: hidden; pointer-events: none; position: absolute;"
>Toggle Action Pad</calcite-tooltip
>
</calcite-action-pad>`;

export const darkModeRTL_TestOnly = (): string => html`
<calcite-action-pad position="start" dir="rtl" class="calcite-mode-dark">
<calcite-action-group>
Expand Down