Skip to content

fix(action-pad): update layout on action-group elements slotted after initialization #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driskull merged 2 commits into from
Sep 20, 2024
Merged

fix(action-pad): update layout on action-group elements slotted after initialization #10355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c1f77e
fix(action-pad): update layout on action-group elements slotted after…
driskull Sep 19, 2024
15b1986
Merge branch 'dev' into dris0000/action-pad-fix-mutation-observer
driskull Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/calcite-components/src/components/action-bar/action-bar.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,18 @@ describe("calcite-action-bar", () => {
await page.waitForChanges();

expect(await group.getProperty("layout")).toBe("vertical");

actionBar.innerHTML = html`
<calcite-action-group></calcite-action-group>
<calcite-action-group></calcite-action-group>
`;
await page.waitForChanges();

const groups = await page.findAll("calcite-action-group");

groups.forEach(async (group) => {
expect(await group.getProperty("layout")).toBe("vertical");
});
});

describe("theme", () => {
Expand Down
12 changes: 12 additions & 0 deletions packages/calcite-components/src/components/action-pad/action-pad.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,18 @@ describe("calcite-action-pad", () => {
await page.waitForChanges();

expect(await group.getProperty("layout")).toBe("vertical");

actionPad.innerHTML = html`
<calcite-action-group></calcite-action-group>
<calcite-action-group></calcite-action-group>
`;
await page.waitForChanges();

const groups = await page.findAll("calcite-action-group");

groups.forEach(async (group) => {
expect(await group.getProperty("layout")).toBe("vertical");
});
});

describe("theme", () => {
Expand Down
2 changes: 2 additions & 0 deletions packages/calcite-components/src/components/action-pad/action-pad.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,14 @@ export class ActionPad
connectConditionalSlotComponent(this);
connectLocalized(this);
connectMessages(this);
this.mutationObserver?.observe(this.el, { childList: true, subtree: true });
}

disconnectedCallback(): void {
disconnectLocalized(this);
disconnectMessages(this);
disconnectConditionalSlotComponent(this);
this.mutationObserver?.disconnect();
}

async componentWillLoad(): Promise<void> {
Expand Down