Conversation
github-actions
Bot
added
the
refactor
jcfranco
changed the title
github-actions
Bot
added
the
chore
benelan
approved these changes
Sep 16, 2024
Contributor
benelan
left a comment
benelan
left a comment
There was a problem hiding this comment.
A couple notes but after those are resolved it LGTM!
Co-authored-by: Ben Elan <no-reply@benelan.dev>
jcfranco
added
the
skip visual snapshots
jcfranco
deleted the
jcfranco/10188-dynamically-track-custom-sass-functions-for-linting
branch
benelan
added a commit
that referenced
this pull request
Sep 17, 2024
…estone-estimates * origin/dev: (997 commits) fix: correct non-standard filled icon names (#10309) fix(panel): initially closed panel should be hidden (#10308) chore(linting): automate tracking of custom Sass functions for stylelint (#10313) chore: tidy up demo pages (#10314) build(deps): update dependency dayjs to v1.11.13 (#10283) build(deps): update dependency jsdom to v24.1.3 (#10298) build(deps): update dependency husky to v9.1.6 (#10318) build(deps): update angular-cli monorepo to v18.2.4 (#10317) docs: update component READMEs (#10316) refactor(stylelint): change config to module format to enable more dynamic options (#10311) refactor: fixup typescript errors (#10295) build(deps): update dependency lint-staged to v15.2.10 (#10302) build(deps): update dependency focus-trap to v7.6.0 (#10281) build(deps): update dependency husky to v9.1.5 (#10297) chore: release next feat(checkbox): add component tokens (#10221) revert: "chore: set default page size for E2E tests (#10219)" (#10299) chore(icons): ensure UI icons follow naming convention (#10292) chore: release next feat: add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history (#10305) ...
benelan
added a commit
that referenced
this pull request
Sep 19, 2024
* origin/dev: fix(shell): fix z-index of slotted popover elements (#10325) fix(dialog): only prevent default on escape key when escapeDisabled is true (#10336) chore: release next feat(carousel): Improve support for high item counts (#10315) feat: add content inline right (#10338) fix: correct non-standard filled icon names (#10309) fix(panel): initially closed panel should be hidden (#10308) chore(linting): automate tracking of custom Sass functions for stylelint (#10313) chore: tidy up demo pages (#10314)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #10188
Summary
This adds a script that tracks all custom Sass functions and updates the metadata for Stylelint’s
function-no-unknownrule, addressing workflow improvements as discussed in #10188 (comment).Our pre-commit hook will run this script if there is a staged Sass file and will add any changes (if any).
Note: this depends on #10311.