Conversation
| "web-adaptor": { | ||
| "alias": ["3.29.7", "gis", "core", "web", "diagram", "nodes", "gis", "storage", "servers", "transfer"], | ||
| "category": "GIS", | ||
| "release": "3.29.7" |
There was a problem hiding this comment.
The version here is incorrect, it will be released as 3.32.0. For reference, the versioning strategy is called semver.
TLDR; The format is <MAJOR>.<MINOR>.<PATCH>
-
When changing an existing icon, use the
fix:prefix in the PR title and increment the<PATCH>number. -
When you add icons, use the
feat:prefix in the PR title, increment the<MINOR>number, and set the<PATCH>number to0. -
When introducing a change that breaks previous functionality (e.g. renaming icons), use the
refactor!:prefix, increment the<MAJOR>number, and set the<MINOR>and<PATCH>versions to0.
Please let me, @jcfranco, and @geospatialem know before installing breaking changes, because they require advanced messaging to our users.
| "connection-middle": { | ||
| "alias": ["3.29.5", "generic", "line", "point", "middle", "connect"], | ||
| "category": "Generic", | ||
| "release": "3.29.5" |
There was a problem hiding this comment.
The versions starting at 3.29.1 are also incorrect. Can you please create a separate fix PR that updates them to the correct versions? You can see which version the icons were released as by checking the changelog
Related Issue: #
Summary
added
web-adaptor-16
web-adaptor-24
web-adaptor-32