Skip to content

feat: add web adaptor#10278

Closed
aphilobos wants to merge 5 commits intodevfrom
aus12066/add-pin-icons
Closed

feat: add web adaptor#10278
aphilobos wants to merge 5 commits intodevfrom
aus12066/add-pin-icons

Conversation

@aphilobos
Copy link
Copy Markdown

Related Issue: #

Summary

added
web-adaptor-16
web-adaptor-24
web-adaptor-32

file_05_screenshot

@aphilobos aphilobos requested a review from arowles September 11, 2024 22:23
@benelan benelan changed the title add web adaptor feat: add web adaptor Sep 11, 2024
"web-adaptor": {
"alias": ["3.29.7", "gis", "core", "web", "diagram", "nodes", "gis", "storage", "servers", "transfer"],
"category": "GIS",
"release": "3.29.7"
Copy link
Copy Markdown
Contributor

@benelan benelan Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version here is incorrect, it will be released as 3.32.0. For reference, the versioning strategy is called semver.

TLDR; The format is <MAJOR>.<MINOR>.<PATCH>

  • When changing an existing icon, use the fix: prefix in the PR title and increment the <PATCH> number.

  • When you add icons, use the feat: prefix in the PR title, increment the <MINOR> number, and set the <PATCH> number to 0.

  • When introducing a change that breaks previous functionality (e.g. renaming icons), use the refactor!: prefix, increment the <MAJOR> number, and set the <MINOR> and <PATCH> versions to 0.

Please let me, @jcfranco, and @geospatialem know before installing breaking changes, because they require advanced messaging to our users.

"connection-middle": {
"alias": ["3.29.5", "generic", "line", "point", "middle", "connect"],
"category": "Generic",
"release": "3.29.5"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions starting at 3.29.1 are also incorrect. Can you please create a separate fix PR that updates them to the correct versions? You can see which version the icons were released as by checking the changelog

@benelan benelan mentioned this pull request Sep 12, 2024
@arowles arowles closed this Sep 12, 2024
@jcfranco jcfranco deleted the aus12066/add-pin-icons branch March 25, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants