feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties by driskull · Pull Request #10249 · Esri/calcite-design-system

driskull · 2024-09-09T18:41:50Z

Related Issue: #7516

Summary

add menuFlipPlacements property
add menuPlacement property
add tests
update stories

…' properties. #7516

macandcheese · 2024-09-09T22:51:53Z

  @Prop({ reflect: true }) dragHandle = false;

+  /**
+   * Defines the available placements that can be used when a flip occurs.


Do we want a bit more context here for "a flip occurs" - maybe something about the rendered action menu flipping? It makes sense to me as someone who knows it refers to internally rendered action menu, but maybe these could be confusing without a more descriptive description (or even prop name)? Applies to others.

Yeah probably. I copied this from another component.

cc @geospatialem @DitwanP on doc

The only component I'm unsure about is how to applies to combobox, is there an initial placement for the component?

If so, WDYT about the following (as you both mentioned will also apply to action-menu, combobox, dropdown, input-date-picker, popover, and split-button).

Specifies the component's fallback `placement` when it's initial or specified `placement` has insufficient space available.

I guess my comment was more about what is being affected by this. In this case, it's "the action menu that is rendered when you slot actions in ___"

"... the component's fallback placement" still isn't clear to a user without context - maybe "Specifies the fallback placement of the component's (internally rendered Action Menu that displays when slotted actions overflow)" (but ... less bad verbiage)

@geospatialem combobox is out of scope I think. It already has flipPlacements just not placement.

Popover, input-date-picker, split-button, and dropdown already has these properties.

Updated components with new doc. The other ones should be tackled separately.

"... the component's fallback placement" still isn't clear to a user without context - maybe "Specifies the fallback placement of the component's (internally rendered Action Menu that displays when slotted actions overflow)" (but ... less bad verbiage)

Ah, I see, for the scope of this PR that might be a good addition. @driskull WDYT about adding that in to the update for the three above. Maybe:

Specifies the component's fallback menu placement when it's initial or specified placement has insufficient space available.

Added a new PR #10261 to cover the remaining components for consistency.

For consistency and readability, would we want to consider updating similar properties to use the menu prefix? I don't recall if we have properties other than overlayPositioning? 🤔

jcfranco · 2024-09-11T00:40:39Z

    );
  });

+  it("sets placement and flipPlacements on internal calcite-action-menu", async () => {


Sidebar: could you work on a test helper for this? It would really help simplify quite a few tests.

…it-button): update flipPlacements description for consistency (#10261) **Related PR:** #10249 (comment) ## Summary Update the `flipPlacements` property description across the design system for consistency and clarity. Includes the following components: - action-menu - combobox - dropdown - input-date-picker - popover - split-button

driskull · 2024-09-19T16:00:26Z

@jcfranco can you review again?

driskull · 2024-09-24T22:08:33Z

+  /**
+   * Determines where the action menu will be positioned.
+   */
+  @Prop({ reflect: true }) menuPlacement: LogicalPlacement;


Do we prefer actionMenuPlacement or is menuPlacement sufficient?

I think the current name is clear and concise.

jcfranco · 2024-09-25T22:26:37Z

+  /**
+   * Determines where the action menu will be positioned.
+   */
+  @Prop({ reflect: true }) menuPlacement: LogicalPlacement;


I think the current name is clear and concise.

jcfranco · 2024-09-25T22:32:57Z

 }
+
+/**
+ * Helper to test if a component has a calcite-action-menu wired up correctly with placement and flipPlacements.


✨🏆✨ This is great, thanks for adding it!

jcfranco · 2024-09-25T22:37:05Z

  @Prop({ reflect: true }) dragHandle = false;

+  /**
+   * Defines the available placements that can be used when a flip occurs.


For consistency and readability, would we want to consider updating similar properties to use the menu prefix? I don't recall if we have properties other than overlayPositioning? 🤔

jcfranco

💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭
💭💭↔️↔️↔️💭↔️💭💭💭💭💭↔️💭↔️↔️↔️↔️💭↔️↔️↔️↔️💭↔️↔️↔️↔️↔️💭↔️💭
💭↔️💭💭💭💭↔️💭💭💭💭💭↔️💭↔️💭💭💭💭↔️💭💭💭💭💭💭↔️💭💭💭↔️💭
💭💭↔️↔️💭💭↔️💭💭↔️💭💭↔️💭↔️↔️↔️💭💭↔️↔️↔️💭💭💭💭↔️💭💭💭↔️💭
💭💭💭💭↔️💭↔️💭↔️💭↔️💭↔️💭↔️💭💭💭💭↔️💭💭💭💭💭💭↔️💭💭💭💭💭
💭↔️↔️↔️💭💭💭↔️💭💭💭↔️💭💭↔️↔️↔️↔️💭↔️↔️↔️↔️💭💭💭↔️💭💭💭↔️💭
💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭💭

driskull · 2024-09-25T22:39:25Z

For consistency and readability, would we want to consider updating similar properties to use the menu prefix? I don't recall if we have properties other than overlayPositioning

Yes, potentially. This would be a breaking change though. 🔧

Should we have a followup issue? cc @DitwanP @geospatialem

We have quite a few components where we use the property name overlayPositioning and it is basically just for the calcite-action-menu.

DitwanP · 2024-09-25T23:21:35Z

Should we have a followup issue? cc @DitwanP @geospatialem

Follow-up Issue

…lid-border-color * origin/dev: feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) fix(list, filter): fix sync between list items and filtered data (#10342) feat(popover): apply component tokens to arrow (#10386) feat(list-item): add `unavailable` property (#10377) fix(segmented-control): honor appearance, layout and scale when items are added after initialization (#10368) fix(action-pad): fix horizontal action group alignment (#10359) fix(combobox): selection-mode="single-persist" correctly selects an item when items have same values (#10366)

…tracking * origin/dev: (40 commits) feat: add parcel parameter (#10384) feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) fix(list, filter): fix sync between list items and filtered data (#10342) feat(popover): apply component tokens to arrow (#10386) feat(list-item): add `unavailable` property (#10377) fix(segmented-control): honor appearance, layout and scale when items are added after initialization (#10368) fix(action-pad): fix horizontal action group alignment (#10359) fix(combobox): selection-mode="single-persist" correctly selects an item when items have same values (#10366) fix(input-time-zone): fix region mode labeling and value mapping (#10345) fix(dropdown): open dropdown on `ArrowDown` & `ArrowUp` keys (#10264) refactor(components): reduce post-migration TypeScript errors (#10356) refactor: do not use Host in functional components (#10352) refactor(tests): reduce TypeScript errors (#10344) feat(alert): add component tokens (#10218) fix(card): properly handle slotted elements (#10378) refactor(panel): remove duplicate tailwind class (#10379) feat(popover, action): add component tokens (#10253) ...

…estone-estimates * origin/dev: (26 commits) test: fix `window.getComputedStyle` arguments (#10424) test(card): remove redundant spy and setup wrapper element (#10429) test(heading): avoid `newSpecPage` usage to ease Lumina migration (#10431) refactor(themed): drop broken, unused, regexp arg support (#10425) docs: component token description consistency (#10430) refactor: prevent mixed Sass mixed declaration warnings (#10426) deprecate: deprecate `enforce-ref-last-prop` rule (#10421) chore(actions): add custom `deprecate` type to semantic-pr check (#10427) chore(issue templates): add arcgis data pipelines to team dropdown (#10418) fix(tooltip): closed tooltips should not reappear (#10420) feat: add dashboard-graph (#10417) fix(input-time-zone): fix region mode quirks after update (#10413) fix(text-area): ensure border-color token doesn't override invalid styles (#10390) ci(changelog): add deprecation commits to changelog automation (#10346) fix: properly set aria attributes on components (#10404) feat: add parcel parameter (#10384) feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) ...

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.32.0</summary> ## [3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0) (2024-09-30) ### Features * Add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter ([#10373](#10373)) ([3ed86ce](3ed86ce)) * Add content inline right ([#10338](#10338)) ([b4530ab](b4530ab)) * Add dashboard-graph ([#10417](#10417)) ([737085a](737085a)) * Add justify ([#10272](#10272)) ([3d6c013](3d6c013)) * Add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history ([#10305](#10305)) ([1e31d43](1e31d43)) * Add parcel parameter ([#10384](#10384)) ([c99be67](c99be67)) * Add trace path and trace path complete ([#10196](#10196)) ([c37ced5](c37ced5)) * Add validate ([#10354](#10354)) ([4160af1](4160af1)) * Add web adaptor ([#10286](#10286)) ([791fd78](791fd78)) * Added connection end left, connection end right, connection middle, connection to connection ([#10198](#10198)) ([3d0f703](3d0f703)) ### Bug Fixes * Correct non-standard filled icon names ([#10309](#10309)) ([7d67334](7d67334)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 1.2.1</summary> ## [1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1) (2024-09-30) ### Deprecations * Deprecate `enforce-ref-last-prop` rule ([#10421](#10421)) ([5fde52d](5fde52d)) </details> <details><summary>@esri/calcite-components: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0) (2024-09-30) ### Features * **accordion-item:** Update component tokens ([ca932b5](ca932b5)) * **action-group, block, panel:** Add `menuPlacement` and `menuFlipPlacements` properties ([#10249](#10249)) ([5ba3112](5ba3112)) * **alert:** Add component tokens ([#10218](#10218)) ([550427b](550427b)) * **alert:** Apply --calcite-alert-corner-radius to internal close button ([#10388](#10388)) ([f50c170](f50c170)) * **avatar:** Add component tokens ([#10280](#10280)) ([f8f881b](f8f881b)) * **carousel:** Improve support for high item counts ([#10315](#10315)) ([6ad2612](6ad2612)) * **checkbox:** Add component tokens ([#10221](#10221)) ([1d87dcf](1d87dcf)) * **chip:** Add component tokens ([#10179](#10179)) ([ff82570](ff82570)) * **dialog, panel:** Add css properties for background-color ([#10387](#10387)) ([d725293](d725293)) * **handle:** Add component tokens ([#10262](#10262)) ([5e73b44](5e73b44)) * **input, input-number, input-text:** Add prefix and suffix width css tokens ([#10206](#10206)) ([7a6ee82](7a6ee82)) * **list-item:** Add `unavailable` property ([#10377](#10377)) ([9332733](9332733)) * **panel:** Improve panel header layout ([#10446](#10446)) ([12f1476](12f1476)) * **popover, action:** Add component tokens ([#10253](#10253)) ([80e8112](80e8112)) * **popover:** Apply component tokens to arrow ([#10386](#10386)) ([2d19268](2d19268)) * **progress:** Add component tokens ([#10267](#10267)) ([8c1259f](8c1259f)) * **text-area:** Add component tokens ([#10343](#10343)) ([d2504b7](d2504b7)) ### Bug Fixes * **action-pad:** Fix horizontal action group alignment ([#10359](#10359)) ([7b03745](7b03745)) * **action-pad:** Update layout on action-group elements slotted after initialization ([#10355](#10355)) ([cf139fa](cf139fa)) * **action:** Prefer `disabled` in favor of `aria-disabled` ([#10367](#10367)) ([1895c07](1895c07)) * **card:** Properly handle slotted elements ([#10378](#10378)) ([99a7148](99a7148)) * **combobox:** Correctly select an item with `selection-mode=‘single-persist’` when items have the same values ([5401ea6](5401ea6)) * **dialog:** Only prevent default on escape key when escapeDisabled is true ([#10336](#10336)) ([0083630](0083630)) * **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys ([#10264](#10264)) ([98548e4](98548e4)) * **input-time-zone:** Fix region mode labeling and value mapping ([#10345](#10345)) ([cf36299](cf36299)) * **input-time-zone:** Fix region mode quirks after update ([#10413](#10413)) ([c137d1f](c137d1f)) * **list, filter:** Fix sync between list items and filtered data ([#10342](#10342)) ([9a66601](9a66601)) * **panel:** Initially closed panel should be hidden ([#10308](#10308)) ([46de96b](46de96b)) * **popover:** Update focus trap elements on mutation observer ([#10357](#10357)) ([725254a](725254a)) * Properly set aria attributes on components ([#10404](#10404)) ([864f3e3](864f3e3)) * Remove aria-disabled from components where necessary ([#10374](#10374)) ([4f8c16c](4f8c16c)) * **segmented-control:** Honor appearance, layout and scale when items are added after initialization ([#10368](#10368)) ([98177f0](98177f0)) * **shell:** Fix z-index of slotted popover elements ([#10325](#10325)) ([7fe1601](7fe1601)) * **text-area:** Ensure border-color token doesn't override invalid styles ([#10390](#10390)) ([699e166](699e166)) * **tooltip:** Closed tooltips should not reappear ([#10420](#10420)) ([a2f3925](a2f3925)) ### Deprecations * **checkbox, radio-button:** Deprecate 'guid' properties ([#10445](#10445)) ([9729ccf](9729ccf)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0 * devDependencies * @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to 1.2.1 </details> <details><summary>@esri/calcite-components-angular: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> <details><summary>@esri/calcite-components-react: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.32.0</summary> ## [3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0) (2024-09-30) ### Features * Add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter ([#10373](#10373)) ([3ed86ce](3ed86ce)) * Add content inline right ([#10338](#10338)) ([b4530ab](b4530ab)) * Add dashboard-graph ([#10417](#10417)) ([737085a](737085a)) * Add justify ([#10272](#10272)) ([3d6c013](3d6c013)) * Add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history ([#10305](#10305)) ([1e31d43](1e31d43)) * Add parcel parameter ([#10384](#10384)) ([c99be67](c99be67)) * Add trace path and trace path complete ([#10196](#10196)) ([c37ced5](c37ced5)) * Add validate ([#10354](#10354)) ([4160af1](4160af1)) * Add web adaptor ([#10286](#10286)) ([791fd78](791fd78)) * Added connection end left, connection end right, connection middle, connection to connection ([#10198](#10198)) ([3d0f703](3d0f703)) ### Bug Fixes * Correct non-standard filled icon names ([#10309](#10309)) ([7d67334](7d67334)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 1.2.1</summary> ## [1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1) (2024-09-30) ### Deprecations * Deprecate `enforce-ref-last-prop` rule ([#10421](#10421)) ([5fde52d](5fde52d)) </details> <details><summary>@esri/calcite-components: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0) (2024-09-30) ### Features * **accordion-item:** Update component tokens ([ca932b5](ca932b5)) * **action-group, block, panel:** Add `menuPlacement` and `menuFlipPlacements` properties ([#10249](#10249)) ([5ba3112](5ba3112)) * **alert:** Add component tokens ([#10218](#10218)) ([550427b](550427b)) * **alert:** Apply --calcite-alert-corner-radius to internal close button ([#10388](#10388)) ([f50c170](f50c170)) * **avatar:** Add component tokens ([#10280](#10280)) ([f8f881b](f8f881b)) * **carousel:** Improve support for high item counts ([#10315](#10315)) ([6ad2612](6ad2612)) * **checkbox:** Add component tokens ([#10221](#10221)) ([1d87dcf](1d87dcf)) * **chip:** Add component tokens ([#10179](#10179)) ([ff82570](ff82570)) * **dialog, panel:** Add css properties for background-color ([#10387](#10387)) ([d725293](d725293)) * **handle:** Add component tokens ([#10262](#10262)) ([5e73b44](5e73b44)) * **input, input-number, input-text:** Add prefix and suffix width css tokens ([#10206](#10206)) ([7a6ee82](7a6ee82)) * **list-item:** Add `unavailable` property ([#10377](#10377)) ([9332733](9332733)) * **panel:** Improve panel header layout ([#10446](#10446)) ([12f1476](12f1476)) * **popover, action:** Add component tokens ([#10253](#10253)) ([80e8112](80e8112)) * **popover:** Apply component tokens to arrow ([#10386](#10386)) ([2d19268](2d19268)) * **progress:** Add component tokens ([#10267](#10267)) ([8c1259f](8c1259f)) * **text-area:** Add component tokens ([#10343](#10343)) ([d2504b7](d2504b7)) ### Bug Fixes * **action-pad:** Fix horizontal action group alignment ([#10359](#10359)) ([7b03745](7b03745)) * **action-pad:** Update layout on action-group elements slotted after initialization ([#10355](#10355)) ([cf139fa](cf139fa)) * **action:** Prefer `disabled` in favor of `aria-disabled` ([#10367](#10367)) ([1895c07](1895c07)) * **card:** Properly handle slotted elements ([#10378](#10378)) ([99a7148](99a7148)) * **combobox:** Correctly select an item with `selection-mode=‘single-persist’` when items have the same values ([5401ea6](5401ea6)) * **dialog:** Only prevent default on escape key when escapeDisabled is true ([#10336](#10336)) ([0083630](0083630)) * **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys ([#10264](#10264)) ([98548e4](98548e4)) * **input-time-zone:** Fix region mode labeling and value mapping ([#10345](#10345)) ([cf36299](cf36299)) * **input-time-zone:** Fix region mode quirks after update ([#10413](#10413)) ([c137d1f](c137d1f)) * **list, filter:** Fix sync between list items and filtered data ([#10342](#10342)) ([9a66601](9a66601)) * **panel:** Initially closed panel should be hidden ([#10308](#10308)) ([46de96b](46de96b)) * **popover:** Update focus trap elements on mutation observer ([#10357](#10357)) ([725254a](725254a)) * Properly set aria attributes on components ([#10404](#10404)) ([864f3e3](864f3e3)) * Remove aria-disabled from components where necessary ([#10374](#10374)) ([4f8c16c](4f8c16c)) * **segmented-control:** Honor appearance, layout and scale when items are added after initialization ([#10368](#10368)) ([98177f0](98177f0)) * **shell:** Fix z-index of slotted popover elements ([#10325](#10325)) ([7fe1601](7fe1601)) * **text-area:** Ensure border-color token doesn't override invalid styles ([#10390](#10390)) ([699e166](699e166)) * **tooltip:** Closed tooltips should not reappear ([#10420](#10420)) ([a2f3925](a2f3925)) ### Deprecations * **checkbox, radio-button:** Deprecate 'guid' properties ([#10445](#10445)) ([9729ccf](9729ccf)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0 * devDependencies * @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to 1.2.1 </details> <details><summary>@esri/calcite-components-angular: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> <details><summary>@esri/calcite-components-react: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

feat(action-group, block, panel): add 'placement' and 'flipPlacements…

e31a3ce

…' properties. #7516

github-actions Bot assigned driskull Sep 9, 2024

github-actions Bot added the enhancement Issues tied to a new feature or request. label Sep 9, 2024

driskull added 3 commits September 9, 2024 11:51

story updates

ece913b

cleanup

d0d5464

Merge branch 'dev' into dris0000/placement-and-flipPlacements

6d662da

driskull marked this pull request as ready for review September 9, 2024 22:03

Merge branch 'dev' into dris0000/placement-and-flipPlacements

80d3dd7

driskull requested review from jcfranco and macandcheese September 9, 2024 22:03

macandcheese reviewed Sep 9, 2024

View reviewed changes

driskull added 3 commits September 10, 2024 11:51

update doc

fdd20ec

doc

ac7c64a

Merge branch 'dev' into dris0000/placement-and-flipPlacements

7648072

geospatialem mentioned this pull request Sep 10, 2024

docs(action-menu, combobox, dropdown, input-date-picker, popover, split-button): update flipPlacements description for consistency #10261

Merged

jcfranco reviewed Sep 11, 2024

View reviewed changes

driskull added 2 commits September 11, 2024 10:36

Review fixes

7711a8b

review fixes

3733001

driskull requested a review from jcfranco September 11, 2024 20:14

review fixes

e0e12d1

driskull changed the title ~~feat(action-group, block, panel): add 'placement' and 'flipPlacements' properties~~ feat(action-group, block, panel): add 'menuPlacement' and 'menuFlipPlacements' properties Sep 20, 2024

driskull commented Sep 24, 2024

View reviewed changes

driskull added this to the 2024-09-30 - 2.13.0 Sep Main release milestone Sep 25, 2024

jcfranco changed the title ~~feat(action-group, block, panel): add 'menuPlacement' and 'menuFlipPlacements' properties~~ feat(action-group, block, panel): add menuPlacement and menuFlipPlacements properties Sep 25, 2024

cleanup

9d85d40

driskull requested review from geospatialem and macandcheese September 25, 2024 22:33

jcfranco reviewed Sep 25, 2024

View reviewed changes

jcfranco approved these changes Sep 25, 2024

View reviewed changes

driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Sep 25, 2024

driskull merged commit 5ba3112 into dev Sep 25, 2024

driskull deleted the dris0000/placement-and-flipPlacements branch September 25, 2024 22:57

DitwanP mentioned this pull request Sep 25, 2024

[Multiple components]: rename the overlayPositioning property for consistency and readability #10391

Open

5 tasks

calcite-admin mentioned this pull request Sep 30, 2024

chore: release main #10457

Merged

benelan mentioned this pull request Oct 1, 2024

chore: release main (#10457) #10461

Closed

calcite-admin mentioned this pull request Oct 1, 2024

chore: release main (#10457) #10463

Merged

jcfranco mentioned this pull request Mar 28, 2025

feat: move Tailwind preset to package #11817

Merged

jcfranco mentioned this pull request Sep 30, 2025

build(deps): update @arcgis dependencies to ^4.34.0-next.151 #12987

Merged

Conversation

driskull commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

driskull commented Sep 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcfranco left a comment

Choose a reason for hiding this comment

Uh oh!

driskull commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DitwanP commented Sep 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

driskull commented Sep 9, 2024 •

edited

Loading

driskull commented Sep 25, 2024 •

edited

Loading