chore(custom-theme): refactor storybook theme for component tokens#10111
Merged
alisonailea merged 9 commits intodevfrom Aug 20, 2024
Merged
chore(custom-theme): refactor storybook theme for component tokens#10111alisonailea merged 9 commits intodevfrom
alisonailea merged 9 commits intodevfrom
Conversation
github-actions
Bot
added
the
chore
driskull
requested changes
Aug 19, 2024
Member
driskull
left a comment
driskull
left a comment
There was a problem hiding this comment.
Nice! 👍
Just a few minor tweaks
jcfranco
approved these changes
Aug 20, 2024
Member
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
Awesome! 🚀
Once comments are addressed, this should be good to merge!
jcfranco
reviewed
Aug 20, 2024
alisonailea
added
the
skip visual snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Breaks the custom-theme storybook page into component files for easier maintenance. This will allow us to move all component token chromatic tests to a single file.