Skip to content

ci(chromatic): ensure skip label added by ci works#10078

Merged
benelan merged 2 commits intodevfrom
benelan/chromatic-check
Aug 15, 2024
Merged

ci(chromatic): ensure skip label added by ci works#10078
benelan merged 2 commits intodevfrom
benelan/chromatic-check

Conversation

@benelan
Copy link
Copy Markdown
Contributor

@benelan benelan commented Aug 15, 2024

Related Issue: #10077

Summary

Events triggered by the default GITHUB_TOKEN will not create new workflow runs. We need the labelling to trigger the Chromatic workflow so it can skip the visual snapshots.

ref: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/triggering-a-workflow#triggering-a-workflow-from-a-workflow

@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Aug 15, 2024
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Aug 15, 2024
@benelan benelan merged commit 76027f9 into dev Aug 15, 2024
@benelan benelan deleted the benelan/chromatic-check branch August 15, 2024 23:16
@github-actions github-actions Bot added this to the 2024-08-27 - Aug Release milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants