Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list: Add event for when a drag starts and ends #8367

Closed
2 of 6 tasks
driskull opened this issue Dec 7, 2023 · 2 comments
Closed
2 of 6 tasks

list: Add event for when a drag starts and ends #8367

driskull opened this issue Dec 7, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2023 December Pri...

Comments

@driskull
Copy link
Member

driskull commented Dec 7, 2023

Check existing issues

Description

Add event for when dragging starts and when it ends

Acceptance Criteria

Two events, one for when dragging starts and one for when it ends.

Relevant Info

https://github.com/SortableJS/Sortable#options

Which Component

list

Example Use Case

In the Maps SDK, we need to know when a drag ends so we can revert the element being moved and let the VDOM handle the updating positioning of the element.

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 7, 2023
@driskull driskull mentioned this issue Dec 7, 2023
Merged
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Dec 7, 2023
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 7, 2023
@driskull driskull self-assigned this Dec 7, 2023
@driskull driskull added this to the 2023 December Priorities milestone Dec 7, 2023
driskull added a commit that referenced this issue Dec 8, 2023
@driskull
feat(list): Add calciteListDragStart and calciteListDragEnd event…
1314605 
…s for when a drag starts and ends. (#8361)

**Related Issue:** #8367

## Summary

- Adds event `calciteListDragEnd` to `list`
- Adds event `calciteListDragStart` to `list`
- Refactors global drag event name in `SortableComponent`.
- Adds test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Dec 8, 2023

🍫 Verified locally on main

@DitwanP DitwanP closed this as completed Dec 8, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP