Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-area: add validation with label requirement + invalid prop for invalid text area styles #6770

Closed
4 tasks
paulcpederson opened this issue Apr 11, 2023 · 4 comments
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ready for dev Issues ready for development implementation.

Comments

@paulcpederson
Copy link
Member

paulcpederson commented Apr 11, 2023

Description

We'd like to move our textareas to use the new calcite-text-area component, but we are missing the status prop we had with calcite-input.

Acceptance Criteria

text-area should have a status prop which allows setting invalid to show an error state with a message below.

  • Add Label* update to required prop
  • Add invalid prop with triggers:
    • required
      • max-length exceeded
  • Deprecate the status prop in favor of an invalid pop as they might not be needed for an "idle" or "valid" status
  • Update invalid styling to a 2px bottom border, for instance (example below):
image

Relevant Info

No response

Which Component

calcite-text-area

Example Use Case

No response

Priority impact

p2 - want for current milestone

Esri team

ArcGIS Online

@paulcpederson paulcpederson added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 11, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Online Issues logged by ArcGIS Online team members. labels Apr 11, 2023
@jcfranco
Copy link
Member

Related: #4598.

@geospatialem
Copy link
Member

Repurposing the above request from the efforts of the validation epic mentioned above, where we will:

  1. Add Label* update to required prop
  2. Add invalid prop with triggers:
    • required
    • max-length exceeded

More information can be sought on the Figma form validation file.

image

@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. and removed needs triage Planning workflow - pending design/dev review. labels Jul 21, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem changed the title text-area: add status prop for invalid text area styles text-area: add validation with label requirement + invalid prop for invalid text area styles Jul 21, 2023
@geospatialem geospatialem added this to the 2023 November Priorities milestone Jul 26, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 12, 2023
@geospatialem
Copy link
Member

Closing in favor of the efforts completed in #8057, where the status property was added, along with an internal input-message for displaying validation messages.

Additional efforts will be completed in #8000 for setting the validity state of the component internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

4 participants