Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-block: handle label not translated #6248

Closed
AdelheidF opened this issue Jan 6, 2023 · 3 comments
Closed

calcite-block: handle label not translated #6248

AdelheidF opened this issue Jan 6, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. enhancement Issues tied to a new feature or request. i18n-l10n issues dealing with internationalization/localization
Milestone
2023 February Pri...

Comments

@AdelheidF
Copy link

AdelheidF commented Jan 6, 2023 •
edited by alisonailea
Loading

Actual Behavior

image

Expected Behavior

handle should be translated

Reproduction Sample

https://codepen.io/afreitag/pen/RwBbgxK

Reproduction Steps

Hover over the drag handle and you'll see the English text "handle". Hover over the expand/collapse icon an you'll see French text.

Reproduction Version

beta.99

Relevant Info

No response

Regression?

don't think so

Impact

medium/high

Esri team

ArcGIS Map Viewer
@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 6, 2023
@github-actions github-actions bot added the ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. label Jan 6, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 9, 2023
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. i18n-l10n issues dealing with internationalization/localization and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Jan 9, 2023
@geospatialem
Copy link
Member

Currently translations are not supported for the handle, and requires a larger effort by Calcite developers and coordination with the i18n team to get the translations back.

Hoping to add this to the February 2023 release, but depending on the time to receive translations, we might see a later addition, such as the March 2023 release.

@alisonailea alisonailea added airtable and removed airtable i18n-l10n issues dealing with internationalization/localization labels Feb 13, 2023
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 16, 2023
@anveshmekala anveshmekala mentioned this issue Feb 16, 2023
Merged
@annierm18 annierm18 added the i18n-l10n issues dealing with internationalization/localization label Feb 16, 2023
jcfranco pushed a commit that referenced this issue Feb 16, 2023
@anveshmekala
chore(handle): add message bundles for translation. (#6493)
924ee69 
**Related Issue:** #6248 

## Summary

This PR will add message bundles required for translation build.
@anveshmekala anveshmekala mentioned this issue Feb 23, 2023
Merged
@anveshmekala anveshmekala mentioned this issue Mar 3, 2023
Merged
jcfranco pushed a commit that referenced this issue Mar 3, 2023
@anveshmekala @jona7150
chore(block): add t9n message bundles. (#6559)
c9b3184 
**Related Issue:** #6248 

## Summary
This PR will add t9n message bundles for `calcite-block` component.

---------

Co-authored-by: jona7150 <[email protected]>
anveshmekala added a commit that referenced this issue Mar 3, 2023
@anveshmekala
feat(block): add built-in localization (#6503)
5e5a7ab 
**Related Issue:** #6248 

## Summary
This PR will add built-in localization support for `calcite-block`
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Mar 3, 2023
@github-actions github-actions bot assigned geospatialem and unassigned anveshmekala Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 15, 2023
@geospatialem
Copy link
Member

Verified on master.

en:

image

ar:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. enhancement Issues tied to a new feature or request. i18n-l10n issues dealing with internationalization/localization
Projects
None yet
Milestone
2023 February Priorities - 1.1.0 - No...
Development

No branches or pull requests
5 participants
@alisonailea @geospatialem @annierm18 @AdelheidF @anveshmekala