Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation and status prop to Input Time Picker #5723

Closed
eriklharper opened this issue Nov 9, 2022 · 4 comments
Closed

Add validation and status prop to Input Time Picker #5723

eriklharper opened this issue Nov 9, 2022 · 4 comments
Assignees
@benelan
Labels
2 - in development Issues that are actively being worked on. blocked This issue is blocked by another issue. Calcite (dev) Issues logged by Calcite developers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. ready for dev Issues ready for development implementation.
Milestone
Stalled

Comments

@eriklharper
Copy link
Contributor

Description

Since the status is deprecated on the label component, there is no built-in way to give a visual indication of the status for input-time-picker.

Acceptance Criteria

Add a status property to input-time-picker that behaves like other input components that implement this property.

Relevant Info

No response

Which Component

input-time-picker

Example Use Case

No response

Esri team

ArcGIS Business/Community Analyst
@eriklharper eriklharper added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 9, 2022
@jcfranco jcfranco mentioned this issue Nov 10, 2022
Open
@jcfranco
Copy link
Member

Linked to validation epic. cc @geospatialem

@benelan benelan added the Calcite (dev) Issues logged by Calcite developers. label Jan 30, 2023
@geospatialem geospatialem added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. labels Jul 21, 2023
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 21, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem
Copy link
Member

Refer to the Figma file for more information:

image

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 21, 2023
@geospatialem geospatialem changed the title Add status prop to Input Time Picker Add validation and status prop to Input Time Picker Jul 21, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@benelan benelan added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 12, 2023
@benelan benelan self-assigned this Sep 12, 2023
@benelan benelan mentioned this issue Oct 2, 2023
Merged
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 2, 2023
benelan added a commit that referenced this issue Oct 2, 2023
@benelan
feat(input-date-picker, input-time-picker): add status property (#7915)
4d53346 
**Related Issues:** #5723, #4276

## Summary

Add `status` property to `calcite-input-date-picker` and
`calcite-input-time-picker`. Validation messages will be added in a
second pass to ensure consistency with the messages displayed for
components with invalid values on form submission.
@benelan benelan mentioned this issue Oct 12, 2023
Closed
4 tasks
@benelan benelan added the blocked This issue is blocked by another issue. label Oct 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@geospatialem
Copy link
Member

Closing in favor of the efforts completed in #8057, where the status property was added, along with an internal input-message for displaying validation messages.

Additional efforts will be completed in #8000 for setting the validity state of the component internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benelan benelan

Labels
2 - in development Issues that are actively being worked on. blocked This issue is blocked by another issue. Calcite (dev) Issues logged by Calcite developers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
Stalled
Development

No branches or pull requests
6 participants
@jcfranco @eriklharper @alisonailea @geospatialem @benelan @brittneytewks