Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

feat: Setting focus to a calcite-action & Flow Menu keyboard navigation #651

Merged
merged 17 commits into from
Dec 19, 2019
Merged

feat: Setting focus to a calcite-action & Flow Menu keyboard navigation #651

merged 17 commits into from
Dec 19, 2019

Conversation

driskull
Copy link
Member

@driskull driskull commented Dec 13, 2019 •
edited
Loading

Related Issue: #58, #475

Summary

feat: Setting focus to a calcite-action & Flow Menu keyboard navigation

example

@driskull driskull added bug Something isn't working enhancement New feature request for an existing component 2 - in development p - high labels Dec 13, 2019
@driskull driskull added this to the Grob Gob Glob Grod milestone Dec 13, 2019
@driskull driskull self-assigned this Dec 13, 2019
@driskull driskull marked this pull request as ready for review December 13, 2019 21:33
@driskull driskull requested a review from a team as a code owner December 13, 2019 21:33
@driskull driskull changed the title fix: Setting focus to a calcite-action & Flow Menu keyboard navigation feat: Setting focus to a calcite-action & Flow Menu keyboard navigation Dec 13, 2019
@driskull
Copy link
Member Author

calcite-components added the setFocus() method to calcite-button here: Esri/calcite-design-system#264

@driskull
Copy link
Member Author

ready for review

@driskull driskull modified the milestones: Grob Gob Glob Grod, Fern Dec 18, 2019
jcfranco
jcfranco approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks, but looks good. 💪:sunglasses:

src/components/calcite-action/calcite-action.tsx Outdated Show resolved Hide resolved
src/components/calcite-flow-item/calcite-flow-item.tsx Outdated Show resolved Hide resolved
src/components/utils/dom.ts Outdated Show resolved Hide resolved
src/components/calcite-flow-item/calcite-flow-item.tsx Outdated Show resolved Hide resolved
src/components/calcite-flow-item/calcite-flow-item.tsx Outdated Show resolved Hide resolved
@driskull driskull merged commit 12754d4 into master Dec 19, 2019
@driskull driskull deleted the dris0000/calcite-flow-key-events branch December 19, 2019 01:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@pr3tori4n pr3tori4n Awaiting requested review from pr3tori4n

Assignees

@driskull driskull

Labels
1 - assigned bug Something isn't working enhancement New feature request for an existing component p - high
Projects
None yet
Milestone
Fern
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco