-
Notifications
You must be signed in to change notification settings - Fork 0
Rename TEE Batcher #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename TEE Batcher #395
Changes from 1 commit
79e486c
075e328
363d6e6
e622dc3
c440c44
933cd66
5be8db8
cb9ea8c
6a7b7c1
4798465
b00d64e
05293f3
2d44253
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,7 +11,7 @@ import ( | |||||
| ) | ||||||
|
|
||||||
| // TestBatcherSwitching tests that the batcher can be switched from the TEE-enabled | ||||||
| // batcher to a fallback non-TEE batcher using the BatchAuthenticator contract. | ||||||
| // batcher to a fallback non-Espresso batcher using the BatchAuthenticator contract. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: The rest of the PR uses "fallback batcher" consistently, but this comment says "non-Espresso batcher". Consider updating for consistency:
Suggested change
|
||||||
| // | ||||||
| // This is the devnet equivalent of TestBatcherSwitching from the E2E tests. | ||||||
| // The test runs two batchers in parallel: | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Same inconsistency here — the log message says "non-Espresso batcher" while the variable is named
fallbackPublished. Consider aligning: