Skip to content

Reorder checks of isValidBatchTx in derivation pipeline #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dailinsubjam merged 2 commits into from
Dec 19, 2025
Merged

Reorder checks of isValidBatchTx in derivation pipeline #310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
794f689
remove warning on every failed tx
dailinsubjam Dec 18, 2025
35096f4
reorder the checks
dailinsubjam Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions op-node/rollup/derive/data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,6 @@ type DataSourceConfig struct {
// 2. the transaction type is any of Legacy, ACL, DynamicFee, Blob, or Deposit (for L3s).
// 3. the transaction has a To() address that matches the batch inbox address
func isValidBatchTx(tx *types.Transaction, receipt *types.Receipt, _ types.Signer, batchInboxAddr, batcherAddr common.Address, logger log.Logger) bool {
if receipt.Status != types.ReceiptStatusSuccessful {
logger.Warn("tx in inbox with invalid status", "hash", tx.Hash(), "status", receipt.Status)
return false
}

// For now, we want to disallow the SetCodeTx type or any future types.
if tx.Type() > types.BlobTxType && tx.Type() != types.DepositTxType {
return false
Expand All @@ -111,6 +106,11 @@ func isValidBatchTx(tx *types.Transaction, receipt *types.Receipt, _ types.Signe
return false
}

if receipt.Status != types.ReceiptStatusSuccessful {
logger.Warn("tx in inbox with invalid status", "hash", tx.Hash(), "status", receipt.Status)
return false
}

// NOTE: contrary to a standard OP batcher, we can safely skip any verification related
// to the sender of the transaction. Indeed the Batch Inbox contract takes care of
// ensuring the sender of the batch information is a legitimate batcher.
Expand Down
Loading