Skip to content

Reducing logging when outputting the batch #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dailinsubjam merged 2 commits into from
Dec 17, 2025
+10 −2
Merged

Reducing logging when outputting the batch #304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a603424
update logging for the batch
dailinsubjam Dec 16, 2025
5a31a75
clean up
dailinsubjam Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions espresso/streamer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,11 @@ func (s *BatchStreamer[B]) processRemainingBatches(ctx context.Context) {
continue
}

s.Log.Trace("Remaining list", "Inserting batch into buffer", "batch", batch)
header := batch.Header()
s.Log.Trace("Remaining list", "Inserting batch into buffer",
"parentHash", header.ParentHash,
"epochNum", header.Number,
"timestamp", header.Time)
s.BatchBuffer.Insert(batch, pos)
keysToDelete = append(keysToDelete, k)
}
Expand Down Expand Up @@ -513,7 +517,11 @@ func (s *BatchStreamer[B]) processEspressoTransaction(ctx context.Context, trans
s.RemainingBatches[hash] = *batch

case BatchAccept:
s.Log.Info("Inserting batch into buffer", "batch", batch)
header := (*batch).Header()
Copy link
Copy Markdown
Member

@shenkeyao shenkeyao Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: why adding * here but not on line 480?

Copy link
Copy Markdown
Author

@dailinsubjam dailinsubjam Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As one is type B and one is type *B

s.Log.Info("Inserting batch into buffer",
"parentHash", header.ParentHash,
"epochNum", header.Number,
"timestamp", header.Time)
s.BatchBuffer.Insert(*batch, pos)

case BatchFuture:
Expand Down
Loading