Decouple DAGroup and TEE-authenticated group#258
Merged
QuentinI merged 3 commits intoag/origin-heightfrom Nov 7, 2025
Merged
Conversation
QuentinI
force-pushed
the
ag/origin-height
branch
from
b4baf0b to
6a6ccb8
Compare
QuentinI
force-pushed
the
ag/parallel-submissions
branch
from
37718cb to
dc29221
Compare
dailinsubjam
approved these changes
Nov 6, 2025
op-batcher/batcher/driver.go
Outdated
| prevCurrentL1 eth.L1BlockRef // cached CurrentL1 from the last syncStatus | ||
|
|
||
| espressoSubmitter *espressoTransactionSubmitter | ||
| teeAuthGroup errgroup.Group |
There was a problem hiding this comment.
Nit: do we want to add a comment mentioning something like sendTx will block when the errgroup is full?
QuentinI
force-pushed
the
ag/parallel-submissions
branch
from
b7df713 to
c569d16
Compare
shenkeyao
approved these changes
Nov 7, 2025
QuentinI
added a commit
that referenced
this pull request
Nov 7, 2025
QuentinI
added a commit
that referenced
this pull request
Nov 10, 2025
QuentinI
added a commit
that referenced
this pull request
Nov 10, 2025
QuentinI
added a commit
that referenced
this pull request
Nov 12, 2025
QuentinI
added a commit
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
daGroup has different semantics, and rightfully is set to limit of 1 by default.
BatchSubmitter.sendTxblock when the errgroup is full instead of returning, which is how it works in non-Espresso contextThis PR does not:
Key places to review: