Skip to content

Remove a Caff node comment #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenkeyao merged 3 commits into from
Sep 5, 2025
Merged

Remove a Caff node comment #225

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cc9b7b
Remove a comment
shenkeyao Sep 3, 2025
18a312a
Restore devnet test in CI
shenkeyao Sep 3, 2025
c6ad5db
Disable the CI again
shenkeyao Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion op-node/rollup/derive/attributes_queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ func (aq *AttributesQueue) Origin() eth.L1BlockRef {
//
// This is similar to the batcher's flow: espressoBatchLoadingLoop -> getSyncStatus -> refresh -> Update -> Next,
// but with a few key differences:
// - CaffNextBatch obtains sync state differently from the batcher, it treated parent.Number() as the latest safe batch number.
// - It only calls Update() when needed and everytime only calls Next() once. While the batcher calls Next() in a loop.
// - It performs additional checks, such as validating the timestamp and parent hash, which does not apply to the batcher.
func CaffNextBatch(s *espresso.EspressoStreamer[EspressoBatch], ctx context.Context, parent eth.L2BlockRef, blockTime uint64, l1Fetcher L1Fetcher) (*SingularBatch, bool, error) {
Expand Down