Skip to content

IL3 Remove redundant "Walking back L1Block" and "will retry" logs #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenkeyao merged 4 commits into from
Aug 29, 2025
Merged

IL3 Remove redundant "Walking back L1Block" and "will retry" logs #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf39bae
Remove logs
shenkeyao Aug 28, 2025
9e43e16
Restore driver log
shenkeyao Aug 28, 2025
7da410a
Remove retry log
shenkeyao Aug 28, 2025
ca6e58f
Restore a log
shenkeyao Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions op-node/rollup/sync/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ func FindL2Heads(ctx context.Context, cfg *rollup.Config, l1 L1Chain, l2 L2Chain
// Exit, find-sync start should start over, to move to an available L1 chain with block-by-number / not-found case.
return nil, fmt.Errorf("failed to retrieve L1 block: %w", err)
}
lgr.Info("Walking back L1Block by hash", "curr", l1Block, "next", b, "l2block", n)
// TODO: Fix upstream compatibility for logs.
// <https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1211175327473209?focus=true>
Comment thread
dailinsubjam marked this conversation as resolved.
l1Block = b
ahead = false
} else if l1Block == (eth.L1BlockRef{}) || n.L1Origin.Hash != l1Block.Hash {
Expand All @@ -177,7 +178,8 @@ func FindL2Heads(ctx context.Context, cfg *rollup.Config, l1 L1Chain, l2 L2Chain
}
l1Block = b
ahead = notFound
lgr.Info("Walking back L1Block by number", "curr", l1Block, "next", b, "l2block", n)
// TODO: Fix upstream compatibility for logs.
// <https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1211175327473209?focus=true>
}

lgr.Trace("walking sync start", "l2block", n)
Expand Down
5 changes: 2 additions & 3 deletions op-service/txmgr/txmgr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,8 @@ func (m *SimpleTxManager) prepare(ctx context.Context, candidate TxCandidate) (*
return nil, ErrClosed
}
tx, err := m.craftTx(ctx, candidate)
if err != nil {
m.l.Warn("Failed to create a transaction, will retry", "err", err)
}
// TODO: Fix upstream compatibility for logs.
// <https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1211175327473209?focus=tr
return tx, err
})
if err != nil {
Expand Down