Handling of BatchFuture validity constant for batches in the Streamer#162
Merged
philippecamacho merged 1 commit intocelo-integration-rebase-13from May 29, 2025
Merged
Conversation
…nstant after verification as this should not happen.
shenkeyao
approved these changes
May 29, 2025
philippecamacho
merged commit 91f9a05
into
celo-integration-rebase-13
18 of 29 checks passed
QuentinI
pushed a commit
that referenced
this pull request
Jun 18, 2025
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
QuentinI
pushed a commit
that referenced
this pull request
Jun 20, 2025
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
QuentinI
pushed a commit
that referenced
this pull request
Jun 20, 2025
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
QuentinI
pushed a commit
that referenced
this pull request
Jun 20, 2025
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
QuentinI
pushed a commit
that referenced
this pull request
Jun 20, 2025
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
shenkeyao
pushed a commit
that referenced
this pull request
Jul 18, 2025
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
shenkeyao
pushed a commit
that referenced
this pull request
Jul 18, 2025
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
dailinsubjam
pushed a commit
that referenced
this pull request
Oct 7, 2025
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
shenkeyao
pushed a commit
that referenced
this pull request
Jan 15, 2026
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
shenkeyao
pushed a commit
that referenced
this pull request
Feb 2, 2026
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
shenkeyao
pushed a commit
that referenced
this pull request
Feb 10, 2026
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
shenkeyao
pushed a commit
that referenced
this pull request
Feb 12, 2026
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
QuentinI
pushed a commit
that referenced
this pull request
Feb 20, 2026
…nstant (#162) The reason is that it should not happen as the CheckBatch does not return BatchFuture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1210114467360887?focus=true
This PR:
Increases the log level to Error if a batch is assigned the
BatchFutureconstant after verification as this should not happen.Key places to review:
All changes.
How to test this PR: