This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Improve solidity compilation process #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveitser
force-pushed
the
feat/t215-abi-extract-only-updated-files
branch
2 times, most recently
from
8fbd17d to
71da1f1
Compare
maybe try remove ? [build-dependencies]
ethers-contract-abigen = { git = "https://github.com/gakonst/ethers-rs" } |
alxiong
reviewed
Jan 11, 2022
Done in 0e7b978 |
- Move extracted ABI files into their own directory to prevent `hardhat compile` from deleting them. - Rewrite build-abi script in python to avoid calling jq twice for each file. This makes the abi extraction part of the script a lot faster. - Check timestmaps of abi files and only update if source is newer.
sveitser
force-pushed
the
feat/t215-abi-extract-only-updated-files
branch
from
0e7b978 to
4fa0bf0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hardhat compilefrom deleting them.file. This makes the abi extraction part of the script a lot faster.
I don't know why we're getting a small change in
Cargo.lock.Close #215