ByteBufferOutput.writeAscii does not work for strings of length one

[ulfeks]

Describe the bug
When writing a single ascii character using ByteBufferOutput.writeAscii, reading will fail with an exception.

To Reproduce

public static void main(String[] args) {
        var os = new ByteArrayOutputStream();
        try (ByteBufferOutput out = new ByteBufferOutput(os)) {
            out.writeAscii("A");
            out.flush();
        }

        try (ByteBufferInput input = new ByteBufferInput(os.toByteArray())) {
            System.out.println(input.readString());
        }
    }

Environment:

• OS: [Windows]
• JDK Version: [JDK18]
• Kryo Version: [e.g. 5.3.0]

Additional context
If I replace "A" with "AB" in the sample code above it works just fine. It also works if I use UnsafeInput/UnsafeOutput instead of ByteBufferOutput/ByteBufferInput

[theigl]

Thanks for the report. This is now fixed on master. Please verify against the latest snapshot build.

[ulfeks]

Thanks for the quick fix! Verified against the latest snapshot and it works fine now. Best regards, Ulf Den ons 5 okt. 2022 14:59Thomas Heigl ***@***.***> skrev:

…

Thanks for the report. This is now fixed on master. Please verify against the latest snapshot build. — Reply to this email directly, view it on GitHub <#920 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG465AMD2VA34HYF4DNHHWLWBV3THANCNFSM6AAAAAAQ4N4PA4> . You are receiving this because you authored the thread.Message ID: ***@***.***>