-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various suggestions for changes and improvements. #35
Conversation
Looks like some good changes.
Regarding this point, I think the free function should be marked unsafe as the caller have to ensure that no methods to it are ever used again else we would run into a use-after-free. The solution would likely be to remove the inner arc from the type and resolve the issue in that way, though this leads to some degradation of the user experience so maybe the api has to be changed around a bit for it. Another way would be to save a flag if it has been freed and then panic, if that is done we don't need unsafe. |
2b1dfd3
to
3ffdea9
Compare
* Remove "None" backend, as this has no practical value. Just call futhark with `c` as the default backend. * Made genfut's string versions of the backends agree with futharks. sequential_c -> c, multicore_c -> multicore. This simplifies the code. Yes it's less user friendly - but that's a problem with futhark. Let's inherit an imperfect convention instead of competing with it. * Unified all the superfluous generator-functions that were identical, except they each used a different string constant for the backend.
* Updating futhark package dependencies should be up to the user, not only because it is slow, but because one may want to use something other than the newest version for various reasons. * It also created an empty lib folder whenever it was called, which is very ugly.
Co-authored-by: Erk <[email protected]>
Co-authored-by: Erk <[email protected]>
I used the built-in github "sync fork" functionality, but that turns out to merge the master branch into the fork, so I undid it, and found a way to rebase instead. This is why the history has been messed up a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr! Will merge it now and touch up some things, then aim to have a pr out by the end of the weekend.
SequentialC
toC
, andMulticoreC
toMulticore
, in line with Futharks convention. This also simplifies the code in a number of places.