Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for parameter correctness in sender app. #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danesh-d
Copy link
Contributor

@IngJohEricsson I added parameter check for sender as well. It would be great if the app can be executed with correct parameters and then it is verified that with correct parameters it works as it should.

DECODER_IP = argv[ix];ix++;
DECODER_PORT = atoi(argv[ix]);ix++;

if (argc > (ix + 1)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indentation

Copy link
Contributor

@mirabilos mirabilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the bad indentation in the last hunk

mirabilos added a commit to qvest-digital/scream that referenced this pull request Jun 29, 2022
Check for parameter correctness in sender app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants