[refactor] Make analyzer and checker options typed #4566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
analyzer 📈
bruntib
force-pushed
the
analyzer_checker_config
branch
6 times, most recently
from
3e5179e to
9af4029
Compare
The analyzer_base.get_analyzer_config() and analyzer_base.get_checker_config() functions returned a list of tuples. The tuple members were accessed by indexing. It was hard to understand what the tuple members represent and what are their possible values. This commit introduces AnalyzerConfig and CheckerConfig types. The functions mentioned above return the list of these objects respectively. cc-verbatim-args-file is a common analyzer option introduced by not the analyzers but CodeChecker. The parameter of this option must be an existing file path. The typed handling of analyzer options helps to emit an error when the provided path doesn't exist.
bruntib
force-pushed
the
analyzer_checker_config
branch
from
9af4029 to
39666a7
Compare
gulyasgergely902
approved these changes
May 22, 2025
elupus
reviewed
Sep 12, 2025
| if cfg.analyzer not in supported_analyzers: | ||
| wrong_configs.append((cfg.analyzer, None)) | ||
| analyzer_configs = { | ||
| analyzer_name: analyzer_class.get_analyzer_config() |
Contributor
There was a problem hiding this comment.
This breaks when clangsa binaries are not existing: get_analyzer_config does not protect for missing binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analyzer_base.get_analyzer_config() and
analyzer_base.get_checker_config() functions returned a list of tuples. The tuple members were accessed by indexing. It was hard to understand what the tuple members represent and what are their possible values.
This commit introduces AnalyzerConfig and CheckerConfig types. The functions mentioned above return the list of these objects respectively.
cc-verbatim-args-file is a common analyzer option introduced by not the analyzers but CodeChecker. The parameter of this option must be an existing file path. The typed handling of analyzer options helps to emit an error when the provided path doesn't exist.