[analyzer] Disable clang flags that cause major undeterminism issues #4372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn off Z3 timeouts added to the Clang Static Analyzer in llvm/llvm-project#95129. We are now aware that these options can often cause nondeterministic behaviour.
Szelethus
added
bugfix 🔨
analyzer 📈
dkrupp
reviewed
Oct 22, 2024
Member
dkrupp
left a comment
dkrupp
left a comment
There was a problem hiding this comment.
isn't this config file just an example? Will it get in effect by default?
| "--enable=core.CallAndMessage", | ||
| "--analyzer-config", | ||
| "clangsa:unroll-loops=true", | ||
| "--analyzer-config", |
Member
There was a problem hiding this comment.
isn't this config file just an example? Will it get in effect by default?
Contributor
Author
There was a problem hiding this comment.
I initially intended to put the change here, I'm just not sure whether hardcoding such a change is appropriate:
https://github.com/Ericsson/codechecker/blob/master/analyzer/codechecker_analyzer/analyzers/clangsa/analyzer.py#L392
@bruntib?
Member
|
I guess this patch can be abandoned... or? |
Contributor
Author
|
Tahts right, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn off Z3 timeouts added to the Clang Static Analyzer in llvm/llvm-project#95129. We are now aware that these options can often cause nondeterministic behaviour.