Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build command argument for CodeChecker log #124

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

Discookie
Copy link
Collaborator

Requires #123, fixes #122.

@Discookie Discookie requested a review from vodorok March 16, 2023 11:51
@Discookie Discookie force-pushed the ericsson/fix-log-command branch from fbd0b68 to 2b9c9e2 Compare March 17, 2023 12:20
@Discookie
Copy link
Collaborator Author

Rebased onto main, should be readable now.

(The spurious test errors are unrelated, I'm investigating them separately.)

@julian-poidevin
Copy link

Hello, any update on this PR being reviewed and merged ?

Copy link
Collaborator

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vodorok vodorok merged commit 23f6f76 into Ericsson:main Mar 29, 2023
@julian-poidevin
Copy link

@vodorok do you know when the next release is coming so this gets integrated ? Thanks

@julian-poidevin
Copy link

@vodorok Any chances this gets integrated into a release soon ?

@julian-poidevin
Copy link

@vodorok @Discookie, any feedback on my previous messages ? 😄

@Discookie
Copy link
Collaborator Author

@julian-poidevin Sorry for the late reply! We'll have a release coming in the next day or two, which will include this as well.

@julian-poidevin
Copy link

@julian-poidevin Sorry for the late reply! We'll have a release coming in the next day or two, which will include this as well.

Great, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codechecker.executor.logBuildCommand setting is ignored
3 participants