Initial multi-root support #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discookie
force-pushed
the
ericsson/multi-workspace
branch
from
025fdbe to
c01b66e
Compare
The file events apparently did not fire consistently fast enough on CI.
Discookie
force-pushed
the
ericsson/multi-workspace
branch
from
c01b66e to
4dcb037
Compare
Discookie
force-pushed
the
ericsson/multi-workspace
branch
from
4dcb037 to
b5d224b
Compare
|
Rebased, should be ready for review now. Requires #125. |
vodorok
approved these changes
May 4, 2023
| @@ -84,7 +84,7 @@ Since CodeChecker-related paths vary greatly between systems, the following sett | |||
| | Name | Description | | |||
| | --- | --- | | |||
| | CodeChecker > Backend > Output folder <br> (default: `${workspaceFolder}/.codechecker`) | The output folder where the CodeChecker analysis files are stored. | | |||
| | CodeChecker > Backend > Compilation database path <br> (default: *(empty)*) | Path to a custom compilation database, in case of a custom build system. The database setup dialog sets the path for the current workspace only. | | |||
| | CodeChecker > Backend > Compilation database path <br> (default: *(empty)*) | Path to a custom compilation database, in case of a custom build system. The database setup dialog sets the path for the current workspace only. Leave blank to use the database in CodeChecker's output folder, or to use CodeChecker's autodetection for multi-root workspaces. | | |||
There was a problem hiding this comment.
It is not entirely clear which compilation database will be used when the field is empty.
| @@ -57,7 +57,7 @@ export class NotificationHandler { | |||
| break; | |||
| } | |||
|
|
|||
| const choiceCommand = options.choices!.find((command) => command.title === choice); | |||
| const choiceCommand = options.choices?.find((command) => command.title === choice); | |||
There was a problem hiding this comment.
From non-null to optional?
There was a problem hiding this comment.
Closing the popup via the X returns choice 'undefined', apparently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #123. Reference: #113, Ericsson/codechecker#3708
Adds support for CodeChecker 6.22's automatic compilation database detection. If no comp.db. is specified, and there is none in CodeChecker's output folder, the extension will use CodeChecker's autodetection (for 6.22 and above). For 6.21, and the mentioned cases, the behavior remains the same.
Remaining tasks:
CodeChecker analyzecan only accept a single file or folder as input, so for multiple files we'd need to autodetect common folders, or run the analysis for each file separately.CodeChecker analyzeif it does not detect a compilation database. Currently it returns code 0, so we'd need to read its output to detect the failure.