Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications overhaul #116

Merged
merged 5 commits into from
Dec 9, 2022

Conversation

Discookie
Copy link
Collaborator

  • Added a sidebar view to show past notifications
  • The notif's actions can still be executed through the sidebar, even if the user disabled pop-up notifications
  • Ported all existing notifications to the new system, but did not add any new ones yet

@Discookie Discookie added enhancement New feature or request refactoring labels Sep 8, 2022
@Discookie Discookie requested a review from vodorok September 8, 2022 02:34
* Add support for updating previous notifications
@Discookie
Copy link
Collaborator Author

Refactored the notifications system, to support updating previously-added notifications.
In future commits, this will be used to display the status of a running CodeChecker process in the more detailed way than it's currently shown, and I want to avoid the need to review it twice.

Copy link
Collaborator

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I need to test it before merging.
Do you have ideas to test this feature?

Copy link
Collaborator

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vodorok vodorok merged commit a1acf61 into Ericsson:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants