Refactor keyboard navigation #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
suggested changes
Apr 4, 2022
There was a problem hiding this comment.
The functionality works properly. I have just one comment. Could you please rebase your branch to make sure all the test cases are run (I already merged your previous patch which contained the tests)? Please also add or modify existing test cases to test this feature.
Based on previously selected steps.
Discookie
force-pushed
the
ericsson/overlapping-positions
branch
from
205e901 to
b94b179
Compare
|
Rebased, also changed the navigation test to contain some overlapping positions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86.
The previously jumped-to step is stored, and future keyboard navigation will be based on that step.
Falls back to the old mechanism when there's no jumped-to step yet.