Add settings to disable CodeChecker version notifs

Ericsson · Jul 15, 2022 · 961ff85 · 961ff85
1 parent 4571084
commit 961ff85
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -150,6 +150,11 @@
           "description": "Enable CodeLens for displaying the reproduction path",
           "default": true
         },
+        "codechecker.executor.enableVersionCheckNotifications": {
+          "type": "boolean",
+          "description": "Enable notifications when CodeChecker is not found or not supported",
+          "default": true
+        },
         "codechecker.executor.runOnSave": {
           "type": "boolean",
           "description": "Controls auto-run of CodeChecker on save",

diff --git a/src/backend/executor/bridge.ts b/src/backend/executor/bridge.ts
@@ -405,6 +405,8 @@ export class ExecutorBridge implements Disposable {
             }
 
             this.versionCheckInProgress = true;
+            const shouldShowWarning = workspace.getConfiguration('codechecker.executor')
+                .get<boolean>('enableVersionCheckNotifications');
 
             const ccPath = getConfigAndReplaceVariables('codechecker.executor', 'executablePath') || 'CodeChecker';
             const commandArgs = this.getVersionCmdArgs();
@@ -448,7 +450,7 @@ export class ExecutorBridge implements Disposable {
 
                             this.versionChecked = false;
 
-                            if (!this.shownVersionWarning) {
+                            if (shouldShowWarning && !this.shownVersionWarning) {
                                 this.shownVersionWarning = true;
                                 let choice;
 
@@ -494,7 +496,7 @@ export class ExecutorBridge implements Disposable {
 
                             this.versionChecked = true;
 
-                            if (this.shownVersionWarning) {
+                            if (shouldShowWarning && this.shownVersionWarning) {
                                 this.shownVersionWarning = false;
 
                                 window.showInformationMessage(
@@ -506,9 +508,11 @@ export class ExecutorBridge implements Disposable {
                         this._bridgeMessages.fire(`>>> Internal error while checking version: ${err}\n`);
                         this.versionChecked = false;
 
-                        window.showErrorMessage(
-                            'CodeChecker: Internal error while checking version - see logs for details'
-                        );
+                        if (shouldShowWarning) {
+                            window.showErrorMessage(
+                                'CodeChecker: Internal error while checking version - see logs for details'
+                            );
+                        }
                     }
 
                     break;
@@ -522,7 +526,7 @@ export class ExecutorBridge implements Disposable {
                     this._bridgeMessages.fire('>>> CodeChecker error while checking version\n');
                     this.versionChecked = false;
 
-                    if (!this.shownVersionWarning) {
+                    if (shouldShowWarning && !this.shownVersionWarning) {
                         this.shownVersionWarning = true;
                         let choice;
 

diff --git a/src/editor/executor.ts b/src/editor/executor.ts
@@ -110,7 +110,13 @@ export class ExecutorAlerts {
             break;
         case ProcessStatus.errored:
             this.statusBarItem.text = '$(testing-error-icon) CodeChecker: analysis errored';
-            window.showErrorMessage('CodeChecker finished with error - see logs for details');
+
+            const shouldShowError = workspace.getConfiguration('codechecker.executor')
+                .get<boolean>('enableVersionCheckNotifications');
+
+            if (shouldShowError) {
+                window.showErrorMessage('CodeChecker finished with error - see logs for details');
+            }
             break;
         default:
             break;