-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading model into pipeline from local filesystem #308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this! I think it's a great addition to the Rust API and just clears up the code a bit. I left a few minor comments regarding docs and one small question.
@Jeadie, I think there are some formatting/linting issues. After those are fixed, I think this should be ready to merge. |
Code Metrics Report=============================================================================== Language Files Lines Code Comments Blanks =============================================================================== Dockerfile 1 34 25 0 9 Happy 1 442 369 0 73 JSON 5 9 9 0 0 Python 21 741 622 21 98 TOML 16 419 378 1 40 ------------------------------------------------------------------------------- Jupyter Notebooks 1 0 0 0 0 |- Markdown 1 60 30 22 8 |- Python 1 96 87 1 8 (Total) 156 117 23 16 ------------------------------------------------------------------------------- Markdown 16 1026 0 758 268 |- BASH 6 205 192 0 13 |- Python 6 121 110 0 11 |- Rust 3 185 172 9 4 (Total) 1537 474 767 296 ------------------------------------------------------------------------------- Rust 81 26428 24327 334 1767 |- Markdown 38 359 0 354 5 (Total) 26787 24327 688 1772 =============================================================================== Total 143 29099 25730 1114 2255 =============================================================================== |
Fixed and ran both |
Thank you! |
@Jeadie Is the local filesystem support only a few days old? Can you explain if HF API is mandatory? Active issue: #326
Perhaps there is some benefit with local filesystem going through HF API? Otherwise it'd probably be better to avoid that, or at least offer a way to opt-out if possible. |
Motivation
mistral.rs
.Changes
Loader
. Fromload_model
load_model_from_hf
load_model_from_path