-
Notifications
You must be signed in to change notification settings - Fork 470
Add the SmolLM3 model #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add the SmolLM3 model #1501
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e47e246
Add model
b4b5a71
Update loader
b8f7c4d
Fix llama config usage
EricLBuehler d7cd5fe
Docs
EricLBuehler a1582cb
Fix config no_rope_layers
EricLBuehler ee60a58
Fix tie_word_embeddings default
EricLBuehler 3ed44f6
Add chat template
EricLBuehler e10e39f
Embed the chat templates
EricLBuehler da899f8
Fix embedding template
EricLBuehler 5d1ba19
enable_thinking default true
EricLBuehler 39afa75
Merge branch 'master' into smollm3
EricLBuehler 2bd7f58
Update examples
EricLBuehler db63ff3
XML tools for smollm3
EricLBuehler ee1609d
Add smollm3 docs
EricLBuehler 42441c7
Fix openai examples
EricLBuehler e860504
Clippy
EricLBuehler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Refactor to eliminate code duplication with Llama3RotaryEmbedding.
The
SmolLm3RotaryEmbeddingimplementation is nearly identical toLlama3RotaryEmbedding(lines 657-971). The only differences are the config type and naming. This violates the DRY principle and will make maintenance more difficult.Consider creating a generic implementation that both can use:
🤖 Prompt for AI Agents