Skip to content

Fix phi3.5 moe (#1447) #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025
Merged

Fix phi3.5 moe (#1447) #1482

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d292ee9
Fix phi3.5 moe accum device
EricLBuehler Jun 18, 2025
f4f9009
Fix again
EricLBuehler Jun 18, 2025
0048860
Fix again
EricLBuehler Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions mistralrs-core/src/models/phi3_5_moe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ impl MoeMlp {
self.router_jitter_noise,
)?;

let mut final_hidden_states = Tensor::zeros((bs * seq, hidden), xs.dtype(), xs.device())?;
let mut final_hidden_states = Tensor::zeros((bs * seq, hidden), xs.dtype(), xs_dev)?;

// One hot encode the selected experts to create an expert mask
// this will be used to easily index which expert to activate
Expand Down Expand Up @@ -471,8 +471,11 @@ impl MoeMlp {
let current_hidden_states = exp_out.broadcast_mul(&current_routing_weights)?;

final_hidden_states = final_hidden_states.index_add(
&top_x.contiguous()?,
&current_hidden_states.squeeze(0)?.to_dtype(xs.dtype())?,
&top_x.contiguous()?.to_device(xs_dev)?,
&current_hidden_states
.squeeze(0)?
.to_dtype(xs.dtype())?
.to_device(xs_dev)?,
0,
)?;
}
Expand Down
Loading