Repository navigation
test: make the retained Ergatis patch tests pass pre-commit (ruff, pyright) - #3
Merged
Merged
Conversation
…right) - test_blocking_no_change_timeout: ruff-format inline comment spacing. - test_astep_releases_state_lock_during_tools: narrow to MessageEvent instead of getattr on Event; pass a fresh list to TestLLM.from_messages (list is invariant). - test_mid_run_reply: build the ActionEvent tool_call as a MessageToolCall, not a dict. Test-only; no behaviour change. Clears the pre-commit failure on #1.
|
Viper is reviewing this pull request — findings and a summary will be posted shortly. |
![viper-review[bot]](https://avatars.githubusercontent.com/in/3274114?s=60&v=4){kind=small}
SummaryNo code quality issues were identified in this test-only change set. DescriptionAdjusts three retained Ergatis patch test files so they pass |
Merged
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
We run OpenHands agents with several MCP servers per conversation. One server that
stopped answering during startup cost us every server's tools, and startup time grew
with each server we added. This PR connects the servers concurrently with a per-server
deadline. We built it into our agent-server image and confirmed the timings in the
comment above, plus a real conversation that used an MCP tool. I reviewed the change
and the trade-off (24s per-server deadline) and I'm happy to adjust it if you prefer
a separate setting.
AGENT:
Why
pre-commitfails on #1 even though that PR only adds the parallel-MCP commit: the failures are in tests from the retained Ergatis patches already onergatis-v1.54.0(1 ruff-format, 4 pyright errors).Summary
test_blocking_no_change_timeout.py: ruff-format inline comment spacing.test_astep_releases_state_lock_during_tools.py: narrow toMessageEventinstead ofgetattronEvent; pass[*script]toTestLLM.from_messages(listis invariant).test_mid_run_reply.py: build theActionEvent.tool_callas aMessageToolCall, not a dict.Test-only, no behaviour change.
Issue Number
N/A — issues are disabled on this fork.
How to Test
Run the full pre-commit suite and the three touched test files from the repo root:
Type
Notes
Merge before #1, then re-run #1's pre-commit check.